Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linter configuration #772

Merged
merged 3 commits into from
Aug 11, 2021
Merged

Update linter configuration #772

merged 3 commits into from
Aug 11, 2021

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Aug 5, 2021

  • remove section for autopep8 since we don't use it
  • Change flake8 settings to exclude excludes since the default list of excluded files is good

@samdoran
Remove settings for autopep8
ba2d91e 
We do not use autopep8 so there is no reason to have it in the config.
@samdoran
Switch flake8 config to extending excludes rather than replacing defa…
4c58071 
…ults
@samdoran samdoran requested a review from Shrews August 5, 2021 17:24
Shrews
Shrews previously requested changes Aug 5, 2021
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
@samdoran samdoran requested a review from Shrews August 10, 2021 14:03
@shanemcd shanemcd added the gate label Aug 11, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shanemcd shanemcd dismissed Shrews’s stale review August 11, 2021 20:17

Seeing if this makes the gate run.

@shanemcd shanemcd added gate and removed gate labels Aug 11, 2021
@ansible-zuul ansible-zuul bot merged commit 4f8cb71 into ansible:devel Aug 11, 2021
@samdoran samdoran deleted the nuke-autopep8 branch August 25, 2021 18:28
samdoran pushed a commit to samdoran/ansible-runner that referenced this pull request Oct 14, 2021
@ansible-zuul @samdoran
Update linter configuration (ansible#772)
19c68cd 
remove section for autopep8 since we don't use it
Change flake8 settings to exclude excludes since the default list of excluded files is good
@samdoran samdoran mentioned this pull request Oct 14, 2021
Merged
ansible-zuul bot added a commit that referenced this pull request Oct 15, 2021
@ansible-zuul
Merge pull request #871 from samdoran/backport/release_2.0/test-fixes
5a8bbb3 
[release-2.0] Backport test fixes

PR #772
PR #815
PR #831
PR #838
PR #859

Reviewed-by: Shane McDonald <me@shanemcd.com>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanemcd shanemcd shanemcd approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul approved these changes

@Shrews Shrews Awaiting requested review from Shrews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samdoran @shanemcd @Shrews