Fix Ansible version comparison in tests #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdoran
approved these changes
Sep 20, 2021
|
Can you remove the unused import of |
Done in the previous commit. |
samdoran
approved these changes
Sep 20, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
Backport to release_2.0: 💚 backport PR created✅ Backport PR branch: Backported as #841 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
Fix Ansible version comparison in tests Current Ansible version string comparison for the test_display_callback.py::test_callback_plugin_records_notify_events test is incorrect as 2.5 does not compare as less than 2.11, etc., so the test is being skipped. Reviewed-by: Sam Doran <sdoran@redhat.com> Reviewed-by: None <None> (cherry picked from commit dc5e91f)
ansible-zuul bot
added a commit
that referenced
this pull request
Sep 21, 2021
…dc5e91f4655d61bdecb437067b408c88bc69841b/pr-837 [PR #837/dc5e91f4 backport][release_2.0] Fix Ansible version comparison in tests This is a backport of PR #837 as merged into devel (dc5e91f). Current Ansible version string comparison for the test_display_callback.py::test_callback_plugin_records_notify_events test is incorrect as 2.5 does not compare as less than 2.11, etc., so the test is being skipped. Reviewed-by: Sam Doran <sdoran@redhat.com> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Ansible version string comparison for the
test_display_callback.py::test_callback_plugin_records_notify_eventstest is incorrect as2.5does not compare as less than2.11, etc., so the test is being skipped.