Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UXD][AAP-25468] AWX - updates to Hosts section buttons and actions #2717

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

tiyiprh
Copy link
Contributor

@tiyiprh tiyiprh commented Jul 15, 2024

https://issues.redhat.com/browse/AAP-25468

Updates to the Hosts section buttons, actions, etc with correct casing/state/wording.

@ZitaNemeckova
Copy link
Member

@tiyiprh You changed tests correctly but they are testing following piece of code:

frontend/awx/resources/inventories/hooks/useInventoriesHostsToolbarActions.tsx
71:        label: t('Delete selected hosts'),

Whe you change that tests should be green :)

@tiyiprh
Copy link
Contributor Author

tiyiprh commented Jul 16, 2024

@ZitaNemeckova

@tiyiprh You changed tests correctly but they are testing following piece of code:

frontend/awx/resources/inventories/hooks/useInventoriesHostsToolbarActions.tsx
71:        label: t('Delete selected hosts'),

Whe you change that tests should be green :)

I updated this file in another PR (#2718) to remove the word "selected." Should I wait for that PR to merge and hopefully that will fix these tests?

@nixocio nixocio merged commit 338d615 into main Aug 12, 2024
23 checks passed
@nixocio nixocio deleted the AWX-hosts-buttons branch August 12, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWX Label to indicate changes relevant to AWX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants