Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub notification link #2876

Closed
wants to merge 3 commits into from
Closed

Hub notification link #2876

wants to merge 3 commits into from

Conversation

appuk
Copy link
Member

@appuk appuk commented Aug 5, 2024

@github-actions github-actions bot added HUB AFW Ansible Framework labels Aug 5, 2024
@appuk appuk requested a review from keithjgrant August 5, 2024 19:27
@himdel
Copy link
Contributor

himdel commented Aug 5, 2024

@appuk there's also an ExternalLink component that already does this (frontend/hub/common/ExternalLink.tsx)

But .. also, IIUC the "tech preview" vs "full experience" bits will be removed again, and that link should now go back to loading HubRoute.Approvals, probably without a new tab? (Not sure if now, or pending the Approvals ..approval re feature parity :))

Copy link

sonarcloud bot commented Aug 5, 2024

@himdel
Copy link
Contributor

himdel commented Aug 6, 2024

Closing, reverted #2759, removing the need to open notifications links in new window

@himdel himdel closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AFW Ansible Framework HUB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants