-
Notifications
You must be signed in to change notification settings - Fork 23.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ios_logging: Fix some smaller issues, add unit test (#32321)
* ios_logging: Fix typo in documentation * ios_logging: Fix traceback when setting buffered destination without size When the size parameter is not configured while configuring the buffered destination, a traceback occurs due to the fact that validate_size expects the parameter to be an int. Explicitely converting value to int makes the check work for every case. * ios_logging: Update size parameter documentation Update the documentation of the size paramter to reflect the current behaviour of setting a default of 4096 for the buffered dest. * ios_logging: Add unit test Add unit test for ios_logging testing the behaviour clarified in the previous commits. * ios_logging: Fix python 2.6 compliance
- Loading branch information
1 parent
a2e4196
commit 53fead7
Showing
3 changed files
with
80 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
test/units/modules/network/ios/fixtures/ios_logging_config.cfg
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
! | ||
logging buffered 5000 | ||
logging console informational | ||
logging facility local0 | ||
logging host 1.2.3.4 transport tcp | ||
logging host 1.2.3.4 | ||
logging host 2.3.4.5 | ||
logging host 1.2.3.4 transport tcp port 1000 | ||
logging host 1.2.3.4 transport udp port 1000 | ||
! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
# | ||
# (c) 2016 Red Hat Inc. | ||
# (c) 2017 Paul Neumann | ||
# | ||
# This file is part of Ansible | ||
# | ||
# Ansible is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU General Public License as published by | ||
# the Free Software Foundation, either version 3 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# Ansible is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with Ansible. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
# Make coding more python3-ish | ||
from __future__ import (absolute_import, division, print_function) | ||
__metaclass__ = type | ||
|
||
import json | ||
|
||
from ansible.compat.tests.mock import patch | ||
from ansible.modules.network.ios import ios_logging | ||
from .ios_module import TestIosModule, load_fixture, set_module_args | ||
|
||
|
||
class TestIosLoggingModule(TestIosModule): | ||
|
||
module = ios_logging | ||
|
||
def setUp(self): | ||
self.mock_get_config = patch('ansible.modules.network.ios.ios_logging.get_config') | ||
self.get_config = self.mock_get_config.start() | ||
|
||
self.mock_load_config = patch('ansible.modules.network.ios.ios_logging.load_config') | ||
self.load_config = self.mock_load_config.start() | ||
|
||
def tearDown(self): | ||
self.mock_get_config.stop() | ||
self.mock_load_config.stop() | ||
|
||
def load_fixtures(self, commands=None): | ||
self.get_config.return_value = load_fixture('ios_logging_config.cfg') | ||
self.load_config.return_value = None | ||
|
||
def test_ios_logging_buffer_size_changed_implicit(self): | ||
set_module_args(dict(dest='buffered')) | ||
commands = ['logging buffered 4096'] | ||
self.execute_module(changed=True, commands=commands) | ||
|
||
def test_ios_logging_buffer_size_changed_explicit(self): | ||
set_module_args(dict(dest='buffered', size=6000)) | ||
commands = ['logging buffered 6000'] | ||
self.execute_module(changed=True, commands=commands) |