Send openstack inventory logs to stderr (#51827)

ansible · Feb 18, 2019 · b159fc3 · b159fc3
1 parent 7fb1549
commit b159fc3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/changelogs/fragments/51827-openstack_logs_to_stderr.yml b/changelogs/fragments/51827-openstack_logs_to_stderr.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - openstack inventory plugin - send logs from sdk to stderr so they do not combine with output
diff --git a/lib/ansible/plugins/inventory/openstack.py b/lib/ansible/plugins/inventory/openstack.py
@@ -108,6 +108,7 @@
 '''
 
 import collections
+import sys
 
 from ansible.errors import AnsibleParserError
 from ansible.plugins.inventory import BaseInventoryPlugin, Constructable, Cacheable
@@ -172,8 +173,10 @@ def parse(self, inventory, loader, path, cache=True):
             else:
                 config_files = None
 
-            # TODO(mordred) Integrate shade's logging with ansible's logging
-            sdk.enable_logging()
+            # Redict logging to stderr so it does not mix with output
+            # particular ansible-inventory JSON output
+            # TODO(mordred) Integrate openstack's logging with ansible's logging
+            sdk.enable_logging(stream=sys.stderr)
 
             cloud_inventory = sdk_inventory.OpenStackInventory(
                 config_files=config_files,