Send openstack inventory logs to stderr #51827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
force-pushed
the
stream_elsewhere
branch
from
23ec3f0
to
6d789b9
Compare
|
I put in a changelog fragement, because I would very much like to backport this. |
ansibot
added
affects_2.8
|
Build succeeded (third-party-check pipeline).
|
|
Build succeeded (third-party-check pipeline).
|
s-hertel
approved these changes
Feb 6, 2019
| # TODO(mordred) Integrate openstack's logging with ansible's logging | ||
| sdk.enable_logging() | ||
| sdk.enable_logging(stream=sys.stderr) |
There was a problem hiding this comment.
I think it's fine if a plugin wants to log to a file, but the only supported data source the plugins have are the data from the inventory file, so it could add a log_file parameter and log there.
Integrating logging with Ansible logging in general would be more complex, and you can read more ranting about this in #51835
ansibot
removed
the
needs_triage
cloudnull
approved these changes
Feb 12, 2019
|
shipit |
ansibot
added
shipit
|
Thanks everybody, merged into |
kdelee
pushed a commit
to kdelee/ansible
that referenced
this pull request
Feb 15, 2019
abadger
pushed a commit
that referenced
this pull request
Feb 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Resolves #50100
This redirects logs from the openstack sdk to stderr. This is a blocker for integrating openstack inventories into our systems.
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/inventory/openstack.py
ADDITIONAL INFORMATION
This was a TODO item for... @Mordred ??
You can improve on this latter, but I need to get error messages out of stdout. You can put them anywhere else you like later. As long as it's not stdout.
See method docs:
https://github.com/openstack/openstacksdk/blob/9675c1fb0b065017a0fadf75f52d8193cce7dd24/openstack/_log.py#L68-L71
Ping @ryanpetrello in relation to ansible/awx#3107