Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause Prompt keeps input hidden in v2 #14160

Closed
mwhite14 opened this issue Jan 27, 2016 · 8 comments · Fixed by #32083
Closed

Pause Prompt keeps input hidden in v2 #14160

mwhite14 opened this issue Jan 27, 2016 · 8 comments · Fixed by #32083
Assignees
@samdoran
Labels
affects_2.2 This issue/PR affects Ansible v2.2 affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@mwhite14
Copy link

In tasks I prompt for an AWS AMI and get the user input using register. Before ansible v2, I was able to see what I was typing in at the prompt. After v2 I am not longer able to see what I am typing.

It seems it now defaults to private, but it there is no way to disable it.
@bcoca bcoca added this to the stable-2.0 milestone Jan 27, 2016
@lystor
Copy link

lystor commented Jan 28, 2016

+1
Please add private option to ansible 2.0 or revert old ansible 1.9 behavior.
Thank you

@girisreenivas
Copy link

@bcoca any ETA on when this will get fixed? Saw it assigned to the stable 2.0 milestone but I don't see this resolved in the 2.1.0.0 release I'm using.

@Renji-FR
Copy link

Renji-FR commented Jul 6, 2016

+1
I have the same issue with Ansible 2.
I can not see my input with private no or without private option.

@bcoca
Copy link
Member

bcoca commented Jul 23, 2016

fix is not easy as we had to rewrite all the terminal input code, the old one used raw_input which allows echo, the new one sets the tty to 'raw' mode which does not.

@bcoca bcoca modified the milestones: stable-2.0, stable-1.9, 2.2.0 Sep 6, 2016
@ansibot ansibot added the affects_2.2 This issue/PR affects Ansible v2.2 label Sep 8, 2016
@ansibot ansibot added the affects_2.3 This issue/PR affects Ansible v2.3 label Dec 13, 2016
@ansibot
Copy link
Contributor

ansibot commented Apr 11, 2017

@mwhite14 Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type
  • ansible version
  • component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE.md

click here for bot help

@ansibot ansibot added needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels Apr 11, 2017
@gundalow gundalow modified the milestone: 2.2.0 Apr 13, 2017
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jun 29, 2017
@prometheanfire prometheanfire mentioned this issue Jul 19, 2017
Closed
@samdoran samdoran self-assigned this Jul 22, 2017
@soumyadipDe
Copy link

Any update on this issue? Without echoing the input the prompting in pause module looks unusable to us.

@samdoran
Copy link
Contributor

@soumyadipDe I'm digging into this. Not a simple fix but doing my best to find a solution.

@samdoran samdoran mentioned this issue Oct 24, 2017
Merged
@samdoran
Copy link
Contributor

Please test with #32083 to see if it works for you.

samdoran added a commit to samdoran/ansible that referenced this issue Oct 26, 2017
@samdoran
Enable ECHO in prompt module
4eb9dc9 
Fixes ansible#14160
ansibot pushed a commit that referenced this issue Oct 26, 2017
@samdoran @ansibot
Enable ECHO in prompt module (#32083)
104934c 
* Enable ECHO in prompt module

Fixes #14160

* Set flags to make it possible to edit echoed input as well as hide control charcters

Only do this if a time limit is not set.

* Consolidate settings
samdoran added a commit that referenced this issue Oct 26, 2017
@samdoran
Enable ECHO in prompt module (#32083)
4a8ffe5 
* Enable ECHO in prompt module

Fixes #14160

* Set flags to make it possible to edit echoed input as well as hide control charcters

Only do this if a time limit is not set.

* Consolidate settings

(cherry picked from commit 104934c)
samdoran added a commit to samdoran/ansible that referenced this issue Oct 26, 2017
@samdoran
Enable ECHO in prompt module
d719db8 
Fixes ansible#14160
bcoca pushed a commit that referenced this issue Nov 3, 2017
@samdoran @bcoca
Add echo option to pause module (#32205)
e65045f 
* Enable ECHO in prompt module

Fixes #14160

* Add option for controlling echo behavior with pause module

* Improve option logic

Allow all options to be used in varying combinations, rather than being mutually exclusive.
Always capture output and return it, even when a time limit is set.

* Add version_added to docs

* Improve behavior of echo output

Set a few more flags to allow interactive deletion and hide control characters.
Do not capture or echo input when a time is set. Tried to get this working nicely, but ran into too many issues/oddities to keep it. Maybe in the future if there is demand for capturing/echoing input when a time is set I'll take another pass at it.
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@samdoran samdoran

Labels
affects_2.2 This issue/PR affects Ansible v2.2 affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable ECHO in pause module samdoran/ansible
9 participants
@bcoca @gundalow @samdoran @mwhite14 @ansibot @lystor @soumyadipDe @girisreenivas @Renji-FR