wrong handler is called when squashed items fail

[willthames]

ISSUE TYPE

• Bug Report

COMPONENT NAME

handler

ANSIBLE VERSION

ansible 2.2.0 (devel a9322e8b8b) last updated 2016/08/24 14:46:19 (GMT +1000)
  lib/ansible/modules/core: (detached HEAD 368ca738fa) last updated 2016/08/24 15:12:35 (GMT +1000)
  lib/ansible/modules/extras: (detached HEAD 0749ce6faa) last updated 2016/08/24 15:12:35 (GMT +1000)
  config file = 
  configured module search path = Default w/o overrides

CONFIGURATION

N/A

OS / ENVIRONMENT

N/A

SUMMARY

Results of modules with squashed items appear to be misinterpreted.

STEPS TO REPRODUCE

- hosts: localhost
  connection: local
  become: true

  tasks:
  - name: install stuff
    yum:
      name: "{{ item }}"
      state: present
    with_items:
    - bash
    - does-not-exist

Note that if you swap bash and does-not-exist around, it works as expected. Basically, because results array is populated by each successful installation, the behaviour is different when it fails on the first item vs the second item.

This is similar to #16766 in that the result of is_failed is incorrect, but for a different reason. I raise this as an issue rather than a PR as I'm not sure what the results should be.

One might argue that this should be an against yum rather than core - but the results of the yum task look reasonable in the absence of documentation that explicitly sets out conditions for module failues, and it seems to be the parsing of the results from yum that is at fault rather than yum module itself.

EXPECTED RESULTS

failure message is displayed in output as when does-not-exist is first item in list:

$ ansible-playbook yum_fail.yml -K -vv
Using /home/wthames/tmp/ansible/ansible.cfg as config file
SUDO password: 

PLAYBOOK: yum_fail.yml *********************************************************
1 plays in yum_fail.yml

PLAY [localhost] ***************************************************************

TASK [setup] *******************************************************************
Wednesday 24 August 2016  15:22:02 +1000 (0:00:00.030)       0:00:00.030 ****** 
ok: [localhost]

TASK [install stuff] ***********************************************************
task path: /home/wthames/tmp/ansible/yum_fail.yml:8
Wednesday 24 August 2016  15:22:05 +1000 (0:00:03.175)       0:00:03.205 ****** 
failed: [localhost] (item=[u'does-not-exist', u'bash']) => {"changed": false, "failed": true, "item": ["does-not-exist", "bash"], "msg": "No Package matching 'does-not-exist' found available, installed or updated", "rc": 0, "results": []}
    to retry, use: --limit @yum_fail.retry

PLAY RECAP *********************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=1   

Wednesday 24 August 2016  15:22:06 +1000 (0:00:00.910)       0:00:04.116 ****** 
=============================================================================== 
setup ------------------------------------------------------------------- 3.18s
 ------------------------------------------------------------------------------
install stuff ----------------------------------------------------------- 0.91s
/home/wthames/tmp/ansible/yum_fail.yml:8 --------------------------------------
Playbook run took 0 days, 0 hours, 0 minutes, 4 seconds

ACTUAL RESULTS

ok message is displayed in output.

ansible-playbook yum_fail.yml -K -vv
Using /home/wthames/tmp/ansible/ansible.cfg as config file
SUDO password: 

PLAYBOOK: yum_fail.yml *********************************************************
1 plays in yum_fail.yml

PLAY [localhost] ***************************************************************

TASK [setup] *******************************************************************
Wednesday 24 August 2016  15:25:05 +1000 (0:00:00.033)       0:00:00.033 ****** 
ok: [localhost]

TASK [install stuff] ***********************************************************
task path: /home/wthames/tmp/ansible/yum_fail.yml:6
Wednesday 24 August 2016  15:25:08 +1000 (0:00:03.253)       0:00:03.287 ****** 
ok: [localhost] => (item=[u'bash', u'does-not-exist']) => {"changed": false, "failed": true, "item": ["bash", "does-not-exist"], "msg": "No Package matching 'does-not-exist' found available, installed or updated", "rc": 0, "results": ["bash-4.3.42-3.fc23.x86_64 providing bash is already installed"]}
    to retry, use: --limit @yum_fail.retry

PLAY RECAP *********************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=1   

Wednesday 24 August 2016  15:25:09 +1000 (0:00:00.935)       0:00:04.222 ****** 
=============================================================================== 
setup ------------------------------------------------------------------- 3.25s
 ------------------------------------------------------------------------------
install stuff ----------------------------------------------------------- 0.94s
/home/wthames/tmp/ansible/yum_fail.yml:6 --------------------------------------
Playbook run took 0 days, 0 hours, 0 minutes, 4 seconds

[abadger]

Tested and dag's fix does indeed fix this:

TASK [install stuff] ***********************************************************
failed: [localhost] (item=[u'bash', u'does-not-exist']) => {"changed": false, "failed": true, "item": ["bash", "does-not-exist"], "msg": "No package matching 'does-not-exist' found available, installed or updated", "rc": 126, "results": ["bash-4.3.43-4.fc25.x86_64 providing bash is already installed", "No package matching 'does-not-exist' found available, installed or updated"]}
        to retry, use: --limit @/srv/ansible/troubleshooting/17208.retry

PLAY RECAP *********************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=1 

Closing fixed in 2.2.0