os_recordset module: Unable to have both A and AAAA records

[precurse]

ISSUE TYPE

• Bug Report

COMPONENT NAME

modules-extra / cloud / openstack / os_recordset

ANSIBLE VERSION

$ ansible --version
ansible 2.2.0.0
  config file = /home/ubuntu/work/playbooks/ansible.cfg
  configured module search path = Default w/o overrides

CONFIGURATION

[defaults]
inventory=inventory/openstack.py

[ssh_connection]
pipelining=False

OS / ENVIRONMENT

Ubuntu 16.04. The task uses delegate_to: localhost

SUMMARY

It seems the os_recordset module is unable to create domain records with both A and AAAA records if they both have the same name. This isn't uncommon in IPv4 and IPv6 deployments. I should be able to create both A and AAAA records for the same name.

STEPS TO REPRODUCE

- hosts: testhost
  tasks:
    - name: Setting up testhost IPv4
      delegate_to: localhost
      os_recordset:
        cloud: dev
        state: present
        zone: "example.com."
        name: "www"
        recordset_type: A
        records: "{{ openstack.accessIPv4 }}"
        ttl: 3600
    - name: Setting up testhost IPv6
      delegate_to: localhost
      os_recordset:
        cloud: dev
        state: present
        zone: "example.com."
        name: "www"
        recordset_type: AAAA
        records: "{{ openstack.accessIPv6 }}"
        ttl: 3600

EXPECTED RESULTS

I would expect both A and AAAA records to be created without error.

ACTUAL RESULTS

Creating A/AAAA record and both an A and AAAA records already exist in OpenStack:

TASK [Setting up testhost IPv4] ************************************************
fatal: [www.example.com -> localhost]: FAILED! => {"changed": false, "failed": true, "msg": "Unable to create recordset www (Inner Exception: Duplicate RecordSet)"}

Creating A record and only an AAAA record already exists in OpenStack:

TASK [Setting up testhost IPv4] ************************************************
fatal: [www.example.com -> localhost]: FAILED! => {"changed": false, "failed": true, "msg": "Error updating recordset www.example.com. (Inner Exception: u'10.0.0.1' is not a 'ipv6')"}

Verbose on:

fatal: [www.example.com -> localhost]: FAILED! => {
    "changed": false, 
    "failed": true, 
    "invocation": {
        "module_args": {
            "api_timeout": null, 
            "auth": null, 
            "auth_type": null, 
            "availability_zone": null, 
            "cacert": null, 
            "cert": null, 
            "cloud": "dev", 
            "description": null, 
            "endpoint_type": "public", 
            "key": null, 
            "name": "www", 
            "records": [
                "10.0.0.1"
            ], 
            "recordset_type": "A", 
            "region_name": null, 
            "state": "present", 
            "timeout": 180, 
            "ttl": 3600, 
            "verify": true, 
            "wait": true, 
            "zone": "example.com."
        }, 
        "module_name": "os_recordset"
    }, 
    "msg": "Error updating recordset www.example.com. (Inner Exception: u'10.0.0.1' is not a 'ipv6')"
}

Creating an AAAA record and an A record already exists in OpenStack

    "msg": "Error updating recordset www.example.com. (Inner Exception: u'<ipv6 address removed>' is not a 'ipv4')"

[precurse]

From the feel of the bug, if an A record already exists and I go to add an AAAA record using Ansible it tries to update the existing A record with an IPv6 address which will obviously fail (and vice versa).

[ansibot]

cc @emonty, @Shrews, @juliakreger, @j2sol, @rcarrillocruz, @Thingee
click here for bot help

[precurse]

So it looks like the module was never designed for multiple records with the same name.. I imagine it will fail if MX, TXT, etc. also exist for a single named record as seen here:
https://github.com/ansible/ansible/blame/devel/lib/ansible/modules/cloud/openstack/os_recordset.py#L188

It explodes if an A + AAAA record exist with the (Inner Exception: Duplicate RecordSet) error above.

After it pulls back recordset with get_recordset, it doesn't actually check the recordset['type'] value to see if it matches with what's being returned.. Which explains the other errors above like trying to update an AAAA record type with an IPv4 address or A record with IPv6 address.