Enhancements to the cobbler inventory script #25926

opoplawski · 2017-06-20T19:34:11Z

SUMMARY

This makes a couple minor and one major change to the cobbler inventory script:

Drop note about script not logging in as it appears to be able to do so now
Make orderby_keyname a config parameter
Handle multiple cobbler servers

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

cobbler inventory

ADDITIONAL INFORMATION

ansibot · 2017-06-20T19:44:02Z

The test ansible-test sanity --test pep8 failed with the following errors:

contrib/inventory/cobbler.py:153:43: E231 missing whitespace after ','
contrib/inventory/cobbler.py:216:20: E111 indentation is not a multiple of four
contrib/inventory/cobbler.py:218:20: E111 indentation is not a multiple of four

click here for bot help

ryansb · 2017-06-21T19:46:43Z

cc/ @alikins

opoplawski · 2017-09-14T20:05:00Z

Any comments here? I've got some further enhancements - handling sub-profiles as sub-groups, which required shifting to the newer json format of output using 'hosts' and 'children'.

jimi-c · 2019-03-27T16:07:54Z

@opoplawski sorry for not getting back sooner on this. It's no longer mergable, curious if you'd want to migrate this to an inventory plugin instead?

ansible#69044)" This reverts commit 70b4ce5.

The module requires updates to work with the current Azure API.

(cherry picked from commit 96f504c) Co-authored-by: Brian Coca <brian.coca+git@gmail.com>

Since Ansible 2.9.8, if the fileglob plugin is passed a path containing a subdirectory of a non-existent directory, it will fail. For example: lookup('fileglob', '/'): ok lookup('fileglob', '/foo'): (non-existent): ok lookup('fileglob', '/foo/bar'): (non-existent): FAIL The exact error depends on Python 2 or 3, but here is the error on Python 2: AttributeError: 'NoneType' object has no attribute 'endswith' And on Python 3: TypeError: expected str, bytes or os.PathLike object, not NoneType This change fixes the issue by skipping paths that are falsey before passing them to os.path.join(). Fixes: ansible#69450

(cherry picked from commit 0d379d4)

…9645) * [stable-2.9] Pin Docker version at 19.03.1 (cherry picked from commit fe941a4) Co-authored-by: Sam Doran <sdoran@redhat.com> * [stable-2.9] Pin docker-ce-cli version in tests (ansible#69620) Installing docker-ce has a dependency of docker-ce-cli. If the version of docker-ci-cli is not specified, it installs the latest version. (cherry picked from commit 889da81)

…69745)

anp, epg are required arguments for module. fatal error occurs when not specified: "FAILED! => {"changed": false, "msg": "missing required arguments: anp, epg"}"

…ble to do so now

- Add exclude_profiles option - Python 3 support - Better cache handling - --debug option - Remove --ignore-settings option - Remove environment variable handling - Create parent profile groups

opoplawski · 2020-05-30T18:31:02Z

This has been rebased against stable-2.9, mainly just so others can see my latest version of the script.

ansibot · 2020-05-30T18:35:05Z

@opoplawski This PR was evaluated as a potentially problematic PR for the following reasons:

More than 50 changed files.
More than 50 commits.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

jimi-c · 2020-06-01T14:13:52Z

@opoplawski seems like it was a bad rebase? There are quite a few conflicting files in odd places.

opoplawski · 2020-06-01T14:23:45Z

It was rebased against release-2.9 instead of master. It appears impossible to change the target branch of the PR. I suppose I could close and open one against that if possible. Or figure out where the script lives now if anywhere..

jimi-c · 2020-06-01T14:28:09Z

Yeah I'd close and re-create, this would not be back-ported to 2.9. Scripts are overall getting deprecated in favor of inventory plugins which work much better. You may want to look at converting it and publishing it via a collection instead.

mattclay · 2020-06-18T23:02:29Z

Closing, since inventory scripts are no longer in the devel branch and features/enhancements to the stable branches are not being accepted.

The cobbler inventory script has been moved to the community.general collection [1], although as @jimi-c points out, it would be better to provide an inventory plugin instead of continuing to work on the inventory script.

[1] https://github.com/ansible-collections/community.general/blob/master/scripts/inventory/cobbler.py

opoplawski · 2020-07-07T04:14:44Z

Converted to inventory plugin:
ansible-collections/community.general#627
https://github.com/cobbler/ansible

ryansb removed the needs_triage Needs a first human triage before being processed. label Jun 21, 2017

ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 29, 2017

ansibot added the inventory Inventory category label Jul 18, 2017

calfonso requested a review from jimi-c August 7, 2017 18:31

ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 24, 2017

ansibot added c:inventory/contrib_script support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 1, 2017

opoplawski force-pushed the cobbler branch from 1bcd443 to a18ed8d Compare September 14, 2017 20:03

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 22, 2017

ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018

ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 29, 2018

mattclay and others added 12 commits May 7, 2020 17:57

Revert "2.9: native types: literal_eval all the things (ansible#68938) (

8b2957a

ansible#69044)" This reverts commit 70b4ce5.

Disable failing azure_rm_dnszone test.

28e9121

The module requires updates to work with the current Azure API.

[stable-2.9] added missing clog for 58461

972e553

(cherry picked from commit 96f504c) Co-authored-by: Brian Coca <brian.coca+git@gmail.com>

New release v2.9.8

ed2a39d

Update Ansible release version to v2.9.8.post0.

457a111

New release v2.9.9

6f83b9a

Update Ansible release version to v2.9.9.post0.

b4b27d6

Explain module docs loss for devel (ansible#68369) (ansible#69546)

7adce02

(cherry picked from commit 0d379d4)

Fix documentation of docker_host_info (it does not delete). (ansible#…

9731787

…69745)

Update mso_schema_site_anp_epg_domain.py (ansible#69703)

5192f68

anp, epg are required arguments for module. fatal error occurs when not specified: "FAILED! => {"changed": false, "msg": "missing required arguments: anp, epg"}"

opoplawski mentioned this pull request May 29, 2020

Dynamic inventory script throws xmlrpc.client.ProtocolError: <ProtocolError for cobbler/cobbler_api: 404 Not Found> cobbler/cobbler#2348

Closed

opoplawski and others added 4 commits May 30, 2020 12:03

[cobbler] Drop note about script not logging in as it appears to be a…

ace202c

…ble to do so now

[cobbler] Make orderby_keyname a config parameter

a2508df

[cobbler] Handle multiple cobbler servers

01bdfcb

inventory/cobbler.py - various enhancements

c598a9d

- Add exclude_profiles option - Python 3 support - Better cache handling - --debug option - Remove --ignore-settings option - Remove environment variable handling - Create parent profile groups

opoplawski force-pushed the cobbler branch from 4d48613 to c598a9d Compare May 30, 2020 18:28

ansibot added has_issue and removed collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels May 30, 2020

mattclay closed this Jun 18, 2020

ansible locked and limited conversation to collaborators Jul 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancements to the cobbler inventory script #25926

Enhancements to the cobbler inventory script #25926

opoplawski commented Jun 20, 2017

ansibot commented Jun 20, 2017

ryansb commented Jun 21, 2017

opoplawski commented Sep 14, 2017

jimi-c commented Mar 27, 2019

opoplawski commented May 30, 2020

ansibot commented May 30, 2020

jimi-c commented Jun 1, 2020

opoplawski commented Jun 1, 2020

jimi-c commented Jun 1, 2020

mattclay commented Jun 18, 2020

opoplawski commented Jul 7, 2020

Enhancements to the cobbler inventory script #25926

Enhancements to the cobbler inventory script #25926

Conversation

opoplawski commented Jun 20, 2017

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibot commented Jun 20, 2017

ryansb commented Jun 21, 2017

opoplawski commented Sep 14, 2017

jimi-c commented Mar 27, 2019

opoplawski commented May 30, 2020

ansibot commented May 30, 2020

jimi-c commented Jun 1, 2020

opoplawski commented Jun 1, 2020

jimi-c commented Jun 1, 2020

mattclay commented Jun 18, 2020

opoplawski commented Jul 7, 2020