Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Idea: Add an AWS NLB Cloud Module #30701

Closed
gamuniz opened this issue Sep 21, 2017 · 12 comments · Fixed by #30907
Closed

Feature Idea: Add an AWS NLB Cloud Module #30701

gamuniz opened this issue Sep 21, 2017 · 12 comments · Fixed by #30907
Labels
affects_2.4 This issue/PR affects Ansible v2.4 aws cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.

Comments

@gamuniz
Copy link
Contributor

gamuniz commented Sep 21, 2017

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

AWS NLB Cloud Module

ANSIBLE VERSION
 ansible --version
ansible 2.4.0.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /bin/ansible
  python version = 2.7.5 (default, Aug  2 2016, 04:20:16) [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)]
CONFIGURATION
OS / ENVIRONMENT

N/A

SUMMARY

AWS just released a new NLB (Network Load Balancer)

STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 feature_idea needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 21, 2017
@shdobxr
Copy link

shdobxr commented Sep 21, 2017

Yep yep!

@s-hertel s-hertel added aws cloud and removed needs_triage Needs a first human triage before being processed. labels Sep 22, 2017
@winstonsimon
Copy link

When can we expect this new module?

@Deepakkothandan
Copy link
Contributor

@s-hertell @wimnat As the NLB is api compatible with ALB, I was able to add support for NLB with minimal modifications to the existing application lb module. Please review the above PR and let me know if any changes are still required,

@jcestef
Copy link

jcestef commented Sep 27, 2017

Does elb_target_group support tcp protocol? No so far.

@Deepakkothandan
Copy link
Contributor

@jcestef The target groups does support TCP

@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2017

@ansibot ansibot added module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 21, 2017
ansibot pushed a commit that referenced this issue Dec 7, 2017
* add support for NLB

* added version for parameter type
s-hertel added a commit that referenced this issue Dec 7, 2017
@ServerNinja
Copy link

Whats the status on this? Will there be NLB support in the next version of Ansible?

@s-hertel
Copy link
Contributor

This was mistakenly closed. The PR for NLB support: #33808.

@s-hertel s-hertel reopened this Dec 22, 2017
@ServerNinja
Copy link

Thank you @s-hertel !

@winstonsimon
Copy link

Any update on this?

@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_idea labels Mar 2, 2018
@biohazd
Copy link
Contributor

biohazd commented Jul 3, 2018

Any update on this?

@willthames
Copy link
Contributor

Ansible now has NLB support: https://docs.ansible.com/ansible/latest/modules/elb_network_lb_module.html#elb-network-lb-module

@ansible ansible locked and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 aws cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants