AWS Network load balancer #33808

wimnat · 2017-12-12T11:30:44Z

SUMMARY

AWS Network Load Balancer module

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

elb_network_lb

ANSIBLE VERSION

2.5

ADDITIONAL INFORMATION

Requires pending PR to move application load balancer code in to new class.
Work still to do:
subnet_mappings work
check any nlb only attributes

ansibot · 2017-12-12T11:33:25Z

cc @willthames
click here for bot help

ansibot · 2017-12-12T11:41:43Z

The test ansible-test sanity --test import --python 2.6 [?] failed with the following error:

lib/ansible/module_utils/aws/elb_utils.py:4:0: ImportError: No module named boto3

The test ansible-test sanity --test import --python 2.7 [?] failed with the following error:

lib/ansible/module_utils/aws/elb_utils.py:4:0: ImportError: No module named boto3

The test ansible-test sanity --test import --python 3.5 [?] failed with the following error:

lib/ansible/module_utils/aws/elb_utils.py:4:0: ImportError: No module named 'boto3'

The test ansible-test sanity --test import --python 3.6 [?] failed with the following error:

lib/ansible/module_utils/aws/elb_utils.py:4:0: ModuleNotFoundError: No module named 'boto3'

The test ansible-test sanity --test import --python 3.7 [?] failed with the following error:

lib/ansible/module_utils/aws/elb_utils.py:4:0: ModuleNotFoundError: No module named 'boto3'

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/cloud/amazon/elb_application_lb.py:383:161: E501 line too long (162 > 160 characters)
lib/ansible/modules/cloud/amazon/elb_application_lb.py:474:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/amazon/elb_application_lb.py:475:5: E265 block comment should start with '# '
lib/ansible/modules/cloud/amazon/elb_application_lb.py:476:5: E265 block comment should start with '# '
lib/ansible/modules/cloud/amazon/elb_network_lb.py:315:161: E501 line too long (162 > 160 characters)

click here for bot help

ansibot · 2017-12-20T00:33:02Z

The test ansible-test sanity --test import --python 2.6 [?] failed with the following error:

lib/ansible/module_utils/aws/elb_utils.py:4:0: ImportError: No module named boto3

The test ansible-test sanity --test import --python 2.7 [?] failed with the following error:

lib/ansible/module_utils/aws/elb_utils.py:4:0: ImportError: No module named boto3

The test ansible-test sanity --test import --python 3.5 [?] failed with the following error:

lib/ansible/module_utils/aws/elb_utils.py:4:0: ImportError: No module named 'boto3'

The test ansible-test sanity --test import --python 3.6 [?] failed with the following error:

lib/ansible/module_utils/aws/elb_utils.py:4:0: ModuleNotFoundError: No module named 'boto3'

The test ansible-test sanity --test import --python 3.7 [?] failed with the following error:

lib/ansible/module_utils/aws/elb_utils.py:4:0: ModuleNotFoundError: No module named 'boto3'

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/module_utils/aws/elbv2.py:390:1: E303 too many blank lines (3)
lib/ansible/modules/cloud/amazon/elb_network_lb.py:315:161: E501 line too long (162 > 160 characters)

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/module_utils/aws/elbv2.py:604:32: undefined-variable Undefined variable 'ALBListeners'

click here for bot help

ansibot · 2017-12-28T02:00:10Z

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/cloud/amazon/elb_network_lb.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"

click here for bot help

s-hertel · 2018-01-15T19:49:30Z

lib/ansible/modules/cloud/amazon/elb_network_lb.py

+
+    region, ec2_url, aws_connect_params = get_aws_connection_info(module, boto3=True)
+
+    if region:


If region is unset it is now handled in boto3_conn so you can remove this conditional.

s-hertel · 2018-01-15T19:57:00Z

lib/ansible/modules/cloud/amazon/elb_network_lb.py

+      - If yes, existing tags will be purged from the resource to match exactly what is defined by I(tags) parameter. If the I(tags) parameter is not set then
+        tags will not be modified.
+    required: false
+    default: yes


~~I think this should default to false probably.~~

Oops, ignore me, sorry. We've had this conversation before having default true is documented. https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/GUIDELINES.md#dealing-with-tags

s-hertel · 2018-01-15T19:57:22Z

lib/ansible/modules/cloud/amazon/elb_network_lb.py

+    description:
+      - If yes, existing listeners will be purged from the ELB to match exactly what is defined by I(listeners) parameter. If the I(listeners) parameter is
+        not set then listeners will not be modified
+    default: yes


Is this safer to default to false?

I think so, I just got burned by this in testing it.

That would be at odds with the default for elb_application_lb

wimnat · 2018-01-16T02:42:06Z

I'm going to hold off on any more work here until #33769 is merged to ease my rebasing pain :)

linuxdynasty · 2018-02-13T14:55:05Z

@wimnat can I use this branch to test our your module?

ansibot · 2018-05-19T09:50:33Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/aws/elbv2.py:266:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/module_utils/aws/elbv2.py:266:1: W293 blank line contains whitespace
lib/ansible/module_utils/aws/elbv2.py:381:161: E501 line too long (162 > 160 characters)

click here for bot help

ansibot · 2018-05-20T03:54:18Z

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/aws/elbv2.py:382:13: E125 continuation line with same indent as next logical line

click here for bot help

ansibot · 2018-05-24T19:46:09Z

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/aws/elbv2.py:381:13: E125 continuation line with same indent as next logical line

click here for bot help

s-hertel · 2018-05-24T20:15:11Z

bot_status

ansibot · 2018-05-24T20:21:06Z

Components

lib/ansible/module_utils/aws/elbv2.py
support: core
maintainers:

lib/ansible/modules/cloud/amazon/elb_network_lb.py
support: community
maintainers:

test/integration/targets/elb_network_lb/aliases
support: community
maintainers:

test/integration/targets/elb_network_lb/defaults/main.yml
support: community
maintainers:

test/integration/targets/elb_network_lb/meta/main.yml
support: community
maintainers:

test/integration/targets/elb_network_lb/tasks/main.yml
support: community
maintainers:

test/integration/targets/elb_network_lb/tasks/test_creating_nlb.yml
support: community
maintainers:

test/integration/targets/elb_network_lb/tasks/test_deleting_nlb.yml
support: community
maintainers:

test/integration/targets/elb_network_lb/tasks/test_modifying_nlb_listeners.yml
support: community
maintainers:

test/integration/targets/elb_network_lb/tasks/test_nlb_bad_listener_options.yml
support: community
maintainers:

test/integration/targets/elb_network_lb/tasks/test_nlb_tags.yml
support: community
maintainers:

test/integration/targets/elb_network_lb/tasks/test_nlb_with_asg.yml
support: community
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 1
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): wimnat
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

* New module - elb_network_lb * Fix creating a load balancer without tags * Linter Fix purging tags Remove extra imports * add support for cross zone lb, doc update and fix tagging * pep8 fixes * Add integration tests for elb_network_lb module * more pep8 * Remove non-applicable option for NLBs * fix target protocol * pep8

wimnat mentioned this pull request Dec 12, 2017

add support for AWS NLB - fixes #30701 #30907

Merged

gundalow removed the needs_triage Needs a first human triage before being processed. label Dec 13, 2017

s-hertel mentioned this pull request Dec 18, 2017

elb_application_lb #33021

Closed

wimnat force-pushed the network_load_balancer branch from 9a2726b to 33864bc Compare December 20, 2017 00:28

s-hertel mentioned this pull request Dec 22, 2017

Feature Idea: Add an AWS NLB Cloud Module #30701

Closed

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 28, 2017

wimnat force-pushed the network_load_balancer branch from 33864bc to 447e897 Compare December 28, 2017 01:45

ansibot added test This PR relates to tests. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 28, 2017

wimnat force-pushed the network_load_balancer branch from 447e897 to 3d45887 Compare December 30, 2017 00:43

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 11, 2018

s-hertel reviewed Jan 15, 2018

View reviewed changes

wimnat mentioned this pull request Jan 22, 2018

Add fix to make network_lb work normally. wimnat/ansible#2

Closed

ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 19, 2018

pep8 fixes

8e24e9b

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label May 20, 2018

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label May 20, 2018

s-hertel added 4 commits May 24, 2018 15:25

Add integration tests for elb_network_lb module

f0e9076

more pep8

1083fc8

Remove non-applicable option for NLBs

0a02763

fix target protocol

e4dd598

pep8

d127642

s-hertel approved these changes May 24, 2018

View reviewed changes

s-hertel requested a review from ryansb May 24, 2018 20:15

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 24, 2018

ryansb approved these changes May 24, 2018

View reviewed changes

ryansb merged commit 858f0fc into ansible:devel May 24, 2018

wimnat deleted the network_load_balancer branch May 25, 2018 03:58

ansible locked and limited conversation to collaborators May 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AWS Network load balancer #33808

AWS Network load balancer #33808

wimnat commented Dec 12, 2017

ansibot commented Dec 12, 2017

ansibot commented Dec 12, 2017

ansibot commented Dec 20, 2017

ansibot commented Dec 28, 2017

s-hertel Jan 15, 2018

s-hertel Jan 15, 2018 •

edited

s-hertel Jan 15, 2018

s-hertel Jan 15, 2018

briantist May 16, 2018

wimnat May 18, 2018

wimnat commented Jan 16, 2018

linuxdynasty commented Feb 13, 2018

ansibot commented May 19, 2018

ansibot commented May 20, 2018

ansibot commented May 24, 2018

s-hertel commented May 24, 2018

ansibot commented May 24, 2018


		region, ec2_url, aws_connect_params = get_aws_connection_info(module, boto3=True)

		if region:

AWS Network load balancer #33808

AWS Network load balancer #33808

Conversation

wimnat commented Dec 12, 2017

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented Dec 12, 2017

ansibot commented Dec 12, 2017

ansibot commented Dec 20, 2017

ansibot commented Dec 28, 2017

s-hertel Jan 15, 2018

Choose a reason for hiding this comment

s-hertel Jan 15, 2018 • edited

Choose a reason for hiding this comment

s-hertel Jan 15, 2018

Choose a reason for hiding this comment

s-hertel Jan 15, 2018

Choose a reason for hiding this comment

briantist May 16, 2018

Choose a reason for hiding this comment

wimnat May 18, 2018

Choose a reason for hiding this comment

wimnat commented Jan 16, 2018

linuxdynasty commented Feb 13, 2018

ansibot commented May 19, 2018

ansibot commented May 20, 2018

ansibot commented May 24, 2018

s-hertel commented May 24, 2018

ansibot commented May 24, 2018

Components

Metadata

s-hertel Jan 15, 2018 •

edited