The quote filter fails on integers

[wknapik]

ISSUE TYPE

Bug Report

COMPONENT NAME

shell

ANSIBLE VERSION

ansible 2.5.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/foo/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Sep 20 2017, 01:25:59) [GCC 7.2.0]

2.5.0.34173.3d63ecb6f3-1

CONFIGURATION

DEFAULT_STDOUT_CALLBACK(/etc/ansible/ansible.cfg) = debug

OS / ENVIRONMENT

N/A

SUMMARY

I was expecting the quote filter to work with integers, without an explicit cast. It does not.

STEPS TO REPRODUCE

ansible -m shell -a 'echo {{ 42|quote }}' localhost

EXPECTED RESULTS

Success.

ACTUAL RESULTS

Failure.

Unexpected templating type error occurred on (echo {{ 42|quote }}): 'int' object is not iterable

[ansibot]

Files identified in the description:

• lib/ansible/modules/commands/shell.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[wknapik]

If this is considered intended behavior, then at least the error message should be improved. When this failed for me the first time, it was in a task with 14 quoted variables. Took a while to figure out where exactly the problem was.

[alikins]

That is a pretty terrible error message. But not sure it can be improved much. The hidden traceback:

Traceback (most recent call last):
  File "/home/adrian/src/ansible/lib/ansible/template/__init__.py", line 676, in do_template
    res = j2_concat(rf)
  File "<template>", line 12, in root
  File "/home/adrian/src/ansible/lib/ansible/plugins/filter/core.py", line 144, in quote
    return shlex_quote(a)
  File "/usr/lib64/python2.7/pipes.py", line 269, in quote
    for c in file:
TypeError: 'int' object is not iterable

The change in #33272 to always convert to text seems reasonable for this case and should avoid that error as well.