Fix dynamic inventory for vagrant does not work on python3 #37631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
c:inventory/contrib_script
inventory
|
Oh, sorry I wasn't clear in my instructions. You'll want to use to_text in
place of all decode() calls. You can also put the import of to_text() with
the other imports.
…On Mon, Mar 19, 2018, 11:56 PM Hideki Saito ***@***.***> wrote:
Modified the part of code what pointed out by @abadger
<https://github.com/abadger>
------------------------------
You can view, comment on, or merge this pull request online at:
#37631
Commit Summary
- Fix dynamic inventory for vagrant does not work on python3 #35129
File Changes
- *M* contrib/inventory/vagrant.py
<https://github.com/ansible/ansible/pull/37631/files#diff-0> (9)
Patch Links:
- https://github.com/ansible/ansible/pull/37631.patch
- https://github.com/ansible/ansible/pull/37631.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37631>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMxWhJ1tqJivHIHyCGPWzCBtLabLNinks5tgKgegaJpZM4SxYnC>
.
|
abadger
changed the title
samdoran
added
c:inventory/contrib_script
and removed
c:inventory/contrib_script
needs_triage
abadger
pushed a commit
to abadger/ansible
that referenced
this pull request
Mar 22, 2018
…7631) * Fix dynamic inventory for vagrant does not work on python3 ansible#35129 (cherry picked from commit 1b121fc)
Merged
|
Merged to devel and added a backport PR for 2.5 #37803 |
nitzmahone
pushed a commit
that referenced
this pull request
Mar 29, 2018
abadger
pushed a commit
that referenced
this pull request
Mar 30, 2018
aleskiontherun
added a commit
to billie-archives/ansible
that referenced
this pull request
Apr 18, 2018
…-fix-2.4 * commit '0adcd7bd1a09489faebed2942b24427bc60f053e': (143 commits) New release v2.4.4.0-1 Update the docs with the 2.4.4 release date New release v2.4.4.0-1 New release v2.4.4.0-0.3.rc2 Add changelog entries for nxos_* fixes add nxos_snapshot test for missing required param (ansible#37248) fix required args for nxos_snapshot and docs improvement (ansible#37232) Add changelog for consul module state=absent fix Add changelog entry for jira py3 fix make jira authentication Python3 compatible (ansible#33862) Add vagrant dyn inv fix to changelog Fix dynamic inventory for vagrant does not work on python3 (ansible#37631) Add digital ocean py3 fix to changelog DigitalOcean: typecast map function for Python3 (ansible#37126) changelog for ansible-pull python3 fix Compare byte strings to byte strings Add ec2 python3 fix to changelog Fix use of user_data field with spot_price in ec2 module (ansible#37628) Add csvfile py3 fix to changelog Fix csvfile traceback on Python3 (ansible#37625) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the part of code what pointed out by @abadger