Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nxos_snapshot test for missing required param #37248

Merged
merged 1 commit into from Mar 9, 2018
Merged

add nxos_snapshot test for missing required param #37248

merged 1 commit into from Mar 9, 2018

Conversation

trishnaguha
Copy link
Member

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

#37227

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/integration/targets/nxos_snapshot/tests/

ANSIBLE VERSION
devel

@trishnaguha trishnaguha added this to Nice to have in 2.4.x Blocker List Mar 9, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 9, 2018

cc @GGabriele @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Mar 9, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Mar 9, 2018
@trishnaguha
add nxos_snapshot test for missing required param
54cab41 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha merged commit 2501834 into ansible:devel Mar 9, 2018
@trishnaguha trishnaguha deleted the nxos_snapshot_test branch March 9, 2018 12:17
@trishnaguha trishnaguha added this to the 2.5.0 milestone Mar 15, 2018
@trishnaguha trishnaguha added this to Need CP into 2.5.1 in zzz NOT USED: Networking Bugs Mar 15, 2018
@trishnaguha trishnaguha self-assigned this Mar 29, 2018
@trishnaguha
Copy link
Member Author

cherry-picked to 2.5

trishnaguha added a commit to trishnaguha/ansible that referenced this pull request Mar 29, 2018
@trishnaguha
add nxos_snapshot test for missing required param (ansible#37248)
c80b4dc 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 2501834)
trishnaguha added a commit that referenced this pull request Mar 29, 2018
@trishnaguha
nxos bugfixes cherry-pick (#38091)
a716fe9 
* Fix nxos_switchport (#37328)

(cherry picked from commit ff57fd0)

* Fix nxos_l2_interface and test typo (#37336)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit ba5e562)

* fix ios_l2_interface (#37389)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit dd37857)

* fix required args for nxos_snapshot and docs improvement (#37232)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit a10df8b)

* add nxos_snapshot test for missing required param (#37248)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 2501834)

* Ensure network_cli nxos test is run only once - remove unnecessary files (#37462)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 957ab02)

* Integration Tests only: nxos_user (#37852)

* add new integration file to nxos_user

* fix shippable error

* change nxapi to connection

* review comments

(cherry picked from commit 63da50e)

* fix UnboundLocalError nxos_bgp_af module (#37610)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 00abe6d)

* Fix nxos_vrf issues (#37092)

* fix nxos_vrf issues

* fix doc

(cherry picked from commit dc61f4c)

* fix nxos_vrf_af issues (#37211)

(cherry picked from commit 74e79d9)

* fix nxos_udld issues (#37418)

(cherry picked from commit 05b266c)

* fix nxos_vlan issues (#38008)

(cherry picked from commit 6f2cb28)

* add changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
abadger pushed a commit that referenced this pull request Mar 30, 2018
@trishnaguha @abadger
add nxos_snapshot test for missing required param (#37248)
846bfbf 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 2501834)
@abadger abadger moved this from Nice to have to Done in 2.4.4 in 2.4.x Blocker List Mar 30, 2018
@trishnaguha trishnaguha moved this from Need CP into 2.5.1 to Done in zzz NOT USED: Networking Bugs Apr 2, 2018
aleskiontherun added a commit to billie-archives/ansible that referenced this pull request Apr 18, 2018
@aleskiontherun
Merge commit '0adcd7bd1a09489faebed2942b24427bc60f053e' into gcpubsub…
dd42db9 
…-fix-2.4

* commit '0adcd7bd1a09489faebed2942b24427bc60f053e': (143 commits)
  New release v2.4.4.0-1
  Update the docs with the 2.4.4 release date
  New release v2.4.4.0-1
  New release v2.4.4.0-0.3.rc2
  Add changelog entries for nxos_* fixes
  add nxos_snapshot test for missing required param (ansible#37248)
  fix required args for nxos_snapshot and docs improvement (ansible#37232)
  Add changelog for consul module state=absent fix
  Add changelog entry for jira py3 fix
  make jira authentication Python3 compatible (ansible#33862)
  Add vagrant dyn inv fix to changelog
  Fix dynamic inventory for vagrant does not work on python3 (ansible#37631)
  Add digital ocean py3 fix to changelog
  DigitalOcean: typecast map function for Python3 (ansible#37126)
  changelog for ansible-pull python3 fix
  Compare byte strings to byte strings
  Add ec2 python3 fix to changelog
  Fix use of user_data field with spot_price in ec2 module (ansible#37628)
  Add csvfile py3 fix to changelog
  Fix csvfile traceback on Python3 (ansible#37625)
  ...
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.4
zzz NOT USED: Networking Bugs
  
Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trishnaguha @ansibot @dagwieers