Fix use of user_data field with spot_price in ec2 module #37628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user_data field is base64 encoded inside of the boto library. In Python3, base64 must be used with byte strings. So we make sure to encode the user_data into a byte string before passing it on to the boto library. Fixes ansible#34978
ansibot
added
aws
bug
s-hertel
removed
the
needs_triage
|
Thanks for reviewing @s-hertel ! |
abadger
added a commit
to abadger/ansible
that referenced
this pull request
Mar 20, 2018
The user_data field is base64 encoded inside of the boto library. In Python3, base64 must be used with byte strings. So we make sure to encode the user_data into a byte string before passing it on to the boto library. Fixes ansible#34978 (cherry picked from commit 0d55081)
nitzmahone
pushed a commit
that referenced
this pull request
Mar 29, 2018
* Fix use of user_data field with spot_price in ec2 module (#37628) The user_data field is base64 encoded inside of the boto library. In Python3, base64 must be used with byte strings. So we make sure to encode the user_data into a byte string before passing it on to the boto library. Fixes #34978 (cherry picked from commit 0d55081) * Python3 ec2 fix added to changelog
aleskiontherun
pushed a commit
to billie-archives/ansible
that referenced
this pull request
Apr 18, 2018
…-fix-2.4 * commit '0adcd7bd1a09489faebed2942b24427bc60f053e': (143 commits) New release v2.4.4.0-1 Update the docs with the 2.4.4 release date New release v2.4.4.0-1 New release v2.4.4.0-0.3.rc2 Add changelog entries for nxos_* fixes add nxos_snapshot test for missing required param (ansible#37248) fix required args for nxos_snapshot and docs improvement (ansible#37232) Add changelog for consul module state=absent fix Add changelog entry for jira py3 fix make jira authentication Python3 compatible (ansible#33862) Add vagrant dyn inv fix to changelog Fix dynamic inventory for vagrant does not work on python3 (ansible#37631) Add digital ocean py3 fix to changelog DigitalOcean: typecast map function for Python3 (ansible#37126) changelog for ansible-pull python3 fix Compare byte strings to byte strings Add ec2 python3 fix to changelog Fix use of user_data field with spot_price in ec2 module (ansible#37628) Add csvfile py3 fix to changelog Fix csvfile traceback on Python3 (ansible#37625) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user_data field is base64 encoded inside of the boto library. In
Python3, base64 must be used with byte strings. So we make sure to
encode the user_data into a byte string before passing it on to the boto
library.
Fixes #34978
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/cloud/amazon/ec2.py
ANSIBLE VERSION