Don't pass keyword args as positional, include file_name #38194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Don't pass keyword args as positional, include file_name. Fixes #38190
Since this code path has existed, we have always been passing
show_content
as thefile_name
parameter. When there was a YAML error, this caused us to try and openTrue
as a file, which results in a hang.This
open
is inAnsibleError._get_error_lines_from_file
At minimum this seems to only affect Mac, and does not affect Linux OSes.
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/action/include_vars.py
ANSIBLE VERSION
ADDITIONAL INFORMATION