Fix ec2_group for numbered protocols (GRE)

[ryansb]

SUMMARY

Reported in #42740

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ec2_group

ANSIBLE VERSION

ADDITIONAL INFORMATION

[ansibot]

cc @adq
click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_group.py:322:20: E127 continuation line over-indented for visual indent

click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_group.py:322:20: E126 continuation line over-indented for hanging indent

click here for bot help

[s-hertel]

This task and the one below need credentials

[s-hertel]

s/Readd/Read

[s-hertel]

This task is failing repeatedly for me.

TASK [ec2_group : test modifying rule and egress rule descriptions (expected changed=true)] ***********************************************
task path: /Users/shertel/Workspace/ansible/test/integration/targets/ec2_group/tasks/main.yml:1177
...
The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_hIDfGf/ansible_module_ec2_group.py", line 709, in authorize
    client.authorize_security_group_ingress(GroupId=group_id, IpPermissions=ip_permissions)
  File "/Users/shertel/Workspace/ansible/venv/python2.7.13/lib/python2.7/site-packages/botocore/client.py", line 314, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/shertel/Workspace/ansible/venv/python2.7.13/lib/python2.7/site-packages/botocore/client.py", line 612, in _make_api_call
    raise error_class(parsed_response, operation_name)
ClientError: An error occurred (InvalidPermission.Duplicate) when calling the AuthorizeSecurityGroupIngress operation: the specified rule "peer: 1001:d00::/24, TCP, from port: 8281, to port: 8281, ALLOW" already exists

fatal: [localhost]: FAILED! => {
    "boto3_version": "1.7.52",
    "botocore_version": "1.10.78",
    "changed": false,
    "error": {
        "code": "InvalidPermission.Duplicate",
        "message": "the specified rule \"peer: 1001:d00::/24, TCP, from port: 8281, to port: 8281, ALLOW\" already exists"
    },
    "invocation": {
        "module_args": {
            ...
        }
    },
    "msg": "Unable to authorize ingress rules: [{'ToPort': 8281, 'IpProtocol': u'tcp', 'Ipv6Ranges': [{'CidrIpv6': '1001:d00::/24', 'Description': 'ipv6 rule desc 2'}], 'FromPort': 8281}]: An error occurred (InvalidPermission.Duplicate) when calling the AuthorizeSecurityGroupIngress operation: the specified rule \"peer: 1001:d00::/24, TCP, from port: 8281, to port: 8281, ALLOW\" already exists",
    "response_metadata": {
        "http_headers": {
            "connection": "close",
            "date": "Thu, 16 Aug 2018 17:38:24 GMT",
            "server": "AmazonEC2",
            "transfer-encoding": "chunked"
        },
        "http_status_code": 400,
        "request_id": "0765a398-b022-424f-a0c7-e7333d366a93",
        "retry_attempts": 0
    }
}

[mattclay]

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/78997/67/tests

[s-hertel]

bot_status

[ansibot]

Components

lib/ansible/module_utils/ec2.py
support: core
maintainers:

lib/ansible/modules/cloud/amazon/ec2_group.py
support: core
maintainers: adq

test/integration/targets/ec2_group/tasks/main.yml
support: core
maintainers: adq

test/integration/targets/ec2_group/tasks/numeric_protos.yml
support: core
maintainers: adq

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): ryansb
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help