Fix ec2_group for numbered protocols such as GRE #45240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix spurious `changed=True` when int is passed as tag * Fix for all AWS module using compare_aws_tags * Handle improperly stringified protocols and allow inconsistency between None/-1 on non-tcp protocols * Add integration test that reproduces the same bug * Return false if the comparsison is not equal (cherry picked from commit 20f2177)
|
Hi @ryansb, Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws. |
ansibot
added
affects_2.7
s-hertel
approved these changes
Sep 5, 2018
s-hertel
removed
the
needs_triage
ansibot
added
needs_revision
|
bot_status |
|
Merged to stable-2.7 for the 2.7.0rc1 release |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Cherry-pick of #42765
Fixes #42765
Fix spurious
changed=Truewhen int is passed as tagFix for all AWS module using compare_aws_tags
Handle improperly stringified protocols and allow inconsistency between None/-1 on non-tcp protocols
Add integration test that reproduces the same bug
Return false if the comparsison is not equal
(cherry picked from commit 20f2177)
ISSUE TYPE
COMPONENT NAME
ec2_group
ANSIBLE VERSION
ADDITIONAL INFORMATION