User locking is not idempotent

[gaddman]

SUMMARY

When locking an already locked user Ansible reports a change.

ISSUE TYPE

• Bug Report

COMPONENT NAME

user.py

ANSIBLE VERSION

ansible 2.6.1
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/chris/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]

Bug introduced by PR #37962

CONFIGURATION

N/A

OS / ENVIRONMENT

Tested on Ubuntu 16.04, but applicable to other *nix platforms.

STEPS TO REPRODUCE

Run the following playbook multiple times.

---
- hosts: localhost
  tasks:
  - user: name=testuser password_lock=yes
    become: true

EXPECTED RESULTS

The first time this is run the module reports changed. Subsequent runs shouldn't report any change, in order to remain idempotent.

ACTUAL RESULTS

Repeated runs of locking or unlocking the password always report changed.

[ansibot]

Files identified in the description:

• lib/ansible/modules/system/user.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @samdoran @sfromm
click here for bot help