Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make password locking in user module idempotent #43671

Merged
merged 5 commits into from
Nov 9, 2018
Merged

make password locking in user module idempotent #43671

merged 5 commits into from
Nov 9, 2018

Conversation

gaddman
Copy link
Contributor

@gaddman gaddman commented Aug 5, 2018

SUMMARY

Fixes #43670 to add idempotency to the user password locking

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

user.py

ANSIBLE VERSION
ansible 2.6.1
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/chris/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

Will add commits for other OSs later.

@ansibot
Copy link
Contributor

ansibot commented Aug 5, 2018

cc @samdoran @sfromm
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 5, 2018
@gaddman
Copy link
Contributor Author

gaddman commented Aug 5, 2018 •
edited

Tested on Linux, other OSes based on documentation. References:

@sivel sivel changed the title user.py password locking make password locking in user module idempotent Aug 6, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 6, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 14, 2018
@jikamens
Copy link

Sure would be nice to get this merged! It's a shame to have fixes ready to go that are just sitting in PRs waiting for someone to merge them.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 8, 2018
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Nov 8, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 9, 2018
@samdoran samdoran merged commit f75a84e into ansible:devel Nov 9, 2018
samdoran pushed a commit to samdoran/ansible that referenced this pull request Nov 9, 2018
@gaddman @samdoran
[stable-2.7] make password locking in user module idempotent (ansible…
b8bce99 
…#43671)

* Simplify logic and add FreeBSD & NetBSD

* Remove incorrect flag for lock and unlock on FreeBSD

* Add tests and changelog

Co-authored-by: Chris Gadd <gaddman@email.com>
(cherry picked from commit f75a84e)

Co-authored-by: Christopher Gadd <gaddman@email.com>
samdoran pushed a commit to samdoran/ansible that referenced this pull request Nov 9, 2018
@gaddman @samdoran
[stable-2.6] make password locking in user module idempotent (ansible…
8ec9785 
…#43671)

* Simplify logic and add FreeBSD & NetBSD

* Remove incorrect flag for lock and unlock on FreeBSD

* Add tests and changelog

Co-authored-by: Chris Gadd <gaddman@email.com>
(cherry picked from commit f75a84e)

Co-authored-by: Christopher Gadd <gaddman@email.com>
abadger pushed a commit that referenced this pull request Nov 9, 2018
@gaddman @abadger
[stable-2.7] make password locking in user module idempotent (#43671)
264bc93 
* Simplify logic and add FreeBSD & NetBSD

* Remove incorrect flag for lock and unlock on FreeBSD

* Add tests and changelog

Co-authored-by: Chris Gadd <gaddman@email.com>
(cherry picked from commit f75a84e)

Co-authored-by: Christopher Gadd <gaddman@email.com>
@gaddman
Copy link
Contributor Author

gaddman commented Nov 11, 2018

Thanks for the correction, all the testing, and the merge @samdoran and @abadger ! Looking forward to this.

Ghilli3 pushed a commit to Ghilli3/ansible that referenced this pull request Nov 12, 2018
@gaddman @Ghilli3
make password locking in user module idempotent (ansible#43671)
d062523 
* Simplify logic and add FreeBSD & NetBSD

* Remove incorrect flag for lock and unlock on FreeBSD

* Add tests and changelog


Co-authored-by: Chris Gadd <gaddman@email.com>
mattclay pushed a commit that referenced this pull request Nov 27, 2018
@gaddman @mattclay
[stable-2.6] make password locking in user module idempotent (#43671)
3267b20 
* Simplify logic and add FreeBSD & NetBSD

* Remove incorrect flag for lock and unlock on FreeBSD

* Add tests and changelog

Co-authored-by: Chris Gadd <gaddman@email.com>
(cherry picked from commit f75a84e)

Co-authored-by: Christopher Gadd <gaddman@email.com>
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@gaddman @mjmayer
make password locking in user module idempotent (ansible#43671)
29f25d8 
* Simplify logic and add FreeBSD & NetBSD

* Remove incorrect flag for lock and unlock on FreeBSD

* Add tests and changelog


Co-authored-by: Chris Gadd <gaddman@email.com>
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@gaddman @Tomorrow9
make password locking in user module idempotent (ansible#43671)
e901751 
* Simplify logic and add FreeBSD & NetBSD

* Remove incorrect flag for lock and unlock on FreeBSD

* Add tests and changelog


Co-authored-by: Chris Gadd <gaddman@email.com>
@gaddman gaddman deleted the idempotent_lock branch December 14, 2018 09:37
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User locking is not idempotent
5 participants
@gaddman @ansibot @jikamens @sivel @samdoran