The ios_l2_interface vlan_range_to_list function may not cast a null variable in integer

[clementtrebuchet]

SUMMARY

In our infrastructure we can have devices configured with a list of vlans whose string ends with a comma.

When splitting the string, the last element is then equal to None which can not be cast to integer

ISSUE TYPE

• Bug Report

COMPONENT NAME

ios_l2_interface

ANSIBLE VERSION

(zion_ansible)[ta-admin-ng5898b@rac group_vars]$ ansible --version
ansible 2.6.2
 config file = /etc/ansible/ansible.cfg
 configured module search path = [u'/usr/share/ansible']
 ansible python module location = /dns/development/ctrebuchet_sandbox/zion_ansible/lib/python2.7/site-packages/ansible
 executable location = /dns/development/ctrebuchet_sandbox/zion_ansible/bin/ansible
 python version = 2.7.8 (default, Oct  9 2014, 10:48:46) [GCC 4.4.7 20120313 (Red Hat 4.4.7-4)]

CONFIGURATION

OS / ENVIRONMENT

Red Hat Enterprise Linux Server release 6.9 (Santiago)

STEPS TO REPRODUCE

having in the configuration a string of vlan like : "228-230,370,378,379,381,385,500,501,580-584,600,646,"

>>> def vlan_range_to_list(vlans):
...     result = []
...     if vlans:
...         for part in vlans.split(','):
...             if part.lower() == 'none':
...                 break
...             if '-' in part:
...                 start, stop = (int(i) for i in part.split('-'))
...                 result.extend(range(start, stop + 1))
...             else:
...                 result.append(int(part))
...     return sorted(result)
... 
>>> vlans = "228-230,370,378,379,381,385,500,501,580-584,600,646,"
>>> vlan_range_to_list(vlans)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 11, in vlan_range_to_list
ValueError: invalid literal for int() with base 10: ''
>>> vlans = "228-230,370,378,379,381,385,500,501,580-584,600,646"
>>> vlan_range_to_list(vlans)
[228, 229, 230, 370, 378, 379, 381, 385, 500, 501, 580, 581, 582, 583, 584, 600, 646]
>>> 

EXPECTED RESULTS

The vlan string is parsed correctly and the function handle all the cases.

>>> def vlan_range_to_list(vlans):
...     result = []
...     if vlans:
...         for part in vlans.split(','):
...             if part.lower() == 'none':
...                 break
...             if part:
...                 if '-' in part:
...                     start, stop = (int(i) for i in part.split('-'))
...                     result.extend(range(start, stop + 1))
...                 else:
...                     result.append(int(part))
...     return sorted(result)
... 
>>> vlans = "228-230,370,378,379,381,385,500,501,580-584,600,646,"
>>> vlan_range_to_list(vlans)
[228, 229, 230, 370, 378, 379, 381, 385, 500, 501, 580, 581, 582, 583, 584, 600, 646]

ACTUAL RESULTS

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 11, in vlan_range_to_list
ValueError: invalid literal for int() with base 10: ''

[ansibot]

Files identified in the description:

• lib/ansible/modules/network/ios/ios_l2_interface.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @Qalthos @rcarrillocruz
click here for bot help

[ansibot]

Hi @clementtrebuchet,

Thank you for the issue, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help