Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panos_security_policy contains deprecated call to be removed in 2.8 #45035

Closed
sivel opened this issue Aug 31, 2018 · 7 comments · Fixed by #47211
Closed

panos_security_policy contains deprecated call to be removed in 2.8 #45035

sivel opened this issue Aug 31, 2018 · 7 comments · Fixed by #47211
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. deprecated This issue/PR relates to a deprecated module. has_pr This issue has an associated PR. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community.
Projects
Ansible 2.8

Comments

@sivel
Copy link
Member

sivel commented Aug 31, 2018

SUMMARY

panos_security_policy contains call to Display.deprecated or AnsibleModule.deprecate and is scheduled for removal

ansible-deprecated-version Deprecated version (2.8) found in call to Display.deprecated or AnsibleModule.deprecate
ISSUE TYPE
  • Bug Report
COMPONENT NAME
lib/ansible/modules/network/panos/_panos_security_policy.py
ANSIBLE VERSION
2.8
CONFIGURATION

N/A

OS / ENVIRONMENT

N/A

STEPS TO REPRODUCE

N/A

EXPECTED RESULTS

N/A

ACTUAL RESULTS

N/A
@sivel sivel added this to Approved - This contains prioritised work that will block the release. It will contained assigned work. in Ansible 2.8 Aug 31, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 31, 2018

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 31, 2018

cc @ivanbojer @jtschichold
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 31, 2018

Hi @sivel,

Thank you for the issue, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. labels Aug 31, 2018
@sivel sivel added deprecated This issue/PR relates to a deprecated module. and removed needs_triage Needs a first human triage before being processed. labels Aug 31, 2018
@gundalow
Copy link
Contributor

gundalow commented Sep 5, 2018

@ivanbojer @jtschichold Hi,
As we've now branched stable-2.7 and devel is targeting Ansible 2.8 we've like to get these removals taken care of early in the release cycle.

There are only two panos_ modules that need updating
This one and #45034

A single PR which does all of these would be fine if that's easier for you,

Please shout on here or in #ansible-devel on Freenode if there are any issues

@abenokraitis
Copy link
Contributor

Per @ivanbojer this module has been deprecated and marked for removal. This issue can be closed AFAICT.

@sivel
Copy link
Member Author

sivel commented Sep 10, 2018

The module is scheduled for removal in Ansible 2.9, but has functionality that is supposed to be removed in 2.8.

If we do not plan on removing the functionality scheduled for removal in 2.8, we need to bump the deprecation notice to align with the 2.9 module removal.

@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2018

cc @shinmog
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed support:community This issue/PR relates to code supported by the Ansible community. labels Sep 18, 2018
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 4, 2018
sivel added a commit to sivel/ansible that referenced this issue Oct 17, 2018
@sivel
Fix versions in module.deprecate call to align with module deprecation.
8327b40 
Fixes ansible#45035 ansible#45034
@sivel sivel mentioned this issue Oct 17, 2018
Merged
@sivel sivel added the has_pr This issue has an associated PR. label Oct 17, 2018
pull bot pushed a commit to webknjaz/ansible that referenced this issue Oct 18, 2018
@sivel @ansibot
Fix versions in module.deprecate call to align with module deprecation.
19416a1 
Fixes ansible#45035 ansible#45034 (ansible#47211)
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this issue Dec 4, 2018
@sivel @Tomorrow9
Fix versions in module.deprecate call to align with module deprecation.
8c0f890 
Fixes ansible#45035 ansible#45034 (ansible#47211)
@thaumos thaumos moved this from Approved - This contains prioritised work that will block the release. It will contained assigned work. to Done - This means done, tests, integration, everything... obvi. in Ansible 2.8 Jan 31, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. deprecated This issue/PR relates to a deprecated module. has_pr This issue has an associated PR. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community.
Projects
No open projects
Ansible 2.8
  
Done - This means done, tests, integr...
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix versions in module.deprecate call to align with module deprecation sivel/ansible
4 participants
@sivel @gundalow @ansibot @abenokraitis