-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port the sns module to boto3 #45634
Port the sns module to boto3 #45634
Conversation
Hi @flowerysong, Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws. |
fb09f02
to
3e390bf
Compare
This is great work, thanks. Could we have a test suite too please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just could use some integration tests to help ensure backwards compatibility.
return topic[u'TopicArn'] | ||
|
||
paginator = client.get_paginator('list_topics') | ||
topic_iterator = paginator.paginate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wrap the client and paginator methods in a try/except and handle BotoCoreError and ClientError
@willthames can you have a second look at this? |
rebuild_merge |
SUMMARY
Ports the sns module to boto3 and AnsibleAWSModule. Adds support for protocol-specific messages targeting newer protocols, including 'lambda'.
ISSUE TYPE
COMPONENT NAME
sns
ANSIBLE VERSION
2.8
ADDITIONAL INFORMATION