Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_dvs_portgroup module: allow comma seperated vlan_id list #46150

Closed
Mikey032 opened this issue Sep 26, 2018 · 5 comments · Fixed by #46628
Closed

vmware_dvs_portgroup module: allow comma seperated vlan_id list #46150

Mikey032 opened this issue Sep 26, 2018 · 5 comments · Fixed by #46628
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community

Comments

@Mikey032
Copy link
Contributor

Mikey032 commented Sep 26, 2018 •
edited

SUMMARY

With the vmware_dvs_portgroup module you can create a vlan trunk by given a single vlan_id or a vlan_id range by the 1-1000 format.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

vmware_dvs_portgroup

ADDITIONAL INFORMATION

It would be nice to also support a comma separated option so you can specify a vlan_id by using 1204,1500 for example.

EDIT: if you try to run the vlan_id parameter with the 1000,1010 notation you get the following error: "need more than 1 value to unpack".
@ansibot
Copy link
Contributor

ansibot commented Sep 26, 2018

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 26, 2018

cc @Akasurde @dav1x @warthog9
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 26, 2018

Hi @mikeysmet,

Thank you for the issue, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. vmware VMware community labels Sep 26, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Sep 26, 2018
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 4, 2018
@Mikey032 Mikey032 mentioned this issue Oct 8, 2018
Merged
@Mikey032
Copy link
Contributor Author

I have created a PR for this feature. Can somebody review #46628?

@ckotte
Copy link
Contributor

ckotte commented Nov 11, 2018

I reviewed it. You might need to create another test case for this feature. @Akasurde needs to review and approve the PR.

StephenSorriaux pushed a commit to StephenSorriaux/ansible that referenced this issue Nov 13, 2018
@Mikey032 @Akasurde
VMware: add multiple VLAN ranges support ansible#46150 (ansible#46628)
6a25e10 
* add multiple VLAN ranges support
* fix pip8
mjmayer pushed a commit to mjmayer/ansible that referenced this issue Nov 30, 2018
@Mikey032 @mjmayer
VMware: add multiple VLAN ranges support ansible#46150 (ansible#46628)
dc57ea1 
* add multiple VLAN ranges support
* fix pip8
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this issue Dec 4, 2018
@Mikey032 @Tomorrow9
VMware: add multiple VLAN ranges support ansible#46150 (ansible#46628)
65a37e3 
* add multiple VLAN ranges support
* fix pip8
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VMware: add multiple vlan ranges support #46150
4 participants
@ansibot @jborean93 @ckotte @Mikey032