Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ec2 regression when assigning a private IP without a public IP #52579

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

s-hertel
Copy link
Contributor

If the private_ip has been provided for the new network interface it shouldn't also be added to top level parameters for run_instances

changelog

SUMMARY

Fixes #48109. Introduced in #43954 (nice spotting @gamuniz) so this should be backported to 2.7.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/ec2.py

…shouldn't also be added to top level parameters for run_instances

changelog
@ansibot
Copy link
Contributor

ansibot commented Feb 19, 2019

@ansibot
Copy link
Contributor

ansibot commented Feb 19, 2019

@s-hertel, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 19, 2019
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Feb 19, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 27, 2019
@s-hertel
Copy link
Contributor Author

s-hertel commented Mar 4, 2019

Fixed the problem for me and was double-checked in #48109 (comment)

@s-hertel s-hertel merged commit 4cf7854 into ansible:devel Mar 4, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
2 participants