Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add azure monitor log profile module #54702

Merged
merged 7 commits into from Aug 26, 2019
Merged

add azure monitor log profile module #54702

merged 7 commits into from Aug 26, 2019

Conversation

yungezz
Copy link
Contributor

@yungezz yungezz commented Apr 2, 2019

SUMMARY

add new module azure_rm_monitorlogprofile. mark as WIP to avoid be merged into 2.8.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 2, 2019

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho @zikalino
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 2, 2019

@yungezz, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 azure cloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 2, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 2, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py:324:34: E131 continuation line unaligned for hanging indent

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py:0:0: E307 version_added should be '2.8'. Currently '2.9'

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 2, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py:324:34: E131 continuation line unaligned for hanging indent

click here for bot help

@ansibleazurebot ansibleazurebot mentioned this pull request Apr 3, 2019
Closed
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2019
@yungezz
Copy link
Contributor Author

yungezz commented Apr 12, 2019

HI @mattclay seems test account doesn't have permission to create log profile, pls see below error:

"Error creating/updating log profile: Azure Error: AuthorizationFailed\nMessage: The client 'xxxxxxxxxxxxxxxxxxx' with object id 'xxxxxxxxxxx' does not have authorization to perform action 'microsoft.insights/logprofiles/write' over scope '/subscriptions/xxxxxxxxxxxxxxxxxxxx'."

https://app.shippable.com/github/ansible/ansible/runs/117172/114/tests

Could you pls grant necessary permission? Thanks.

@mattclay
Copy link
Member

@yungezz I don't think we'll be able to test this with our current CI system. This feature appears to operate at the subscription level, rather than the resource group or resource level. We don't have a safe way to expose privileges for managing the subscription currently.

You can still create tests and run them locally, but you'll need to mark the test unsupported in the aliases file to have it skipped in CI.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 12, 2019
@yungezz
Copy link
Contributor Author

yungezz commented Apr 15, 2019

got it. thanks Matt @mattclay .

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 16, 2019
@yungezz yungezz changed the title [WIP] add azure monitor log profile module add azure monitor log profile module Apr 16, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Apr 16, 2019
@yungezz
Copy link
Contributor Author

yungezz commented Apr 16, 2019

ready_for_review

@ansibot
Copy link
Contributor

ansibot commented Apr 16, 2019

@Madhura-CSI @brusMX @caohai @cperrin88 @devigned @gustavomcarmo @haroldwongms @iphilpot @julienstroheker @lmazuel @obsoleted @sozercan @techknowlogick @trstringer @tstringer @xscript @yaweiw @yuwzho

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@Fred-sun
Copy link
Contributor

Fred-sun commented May 5, 2019

@yuwzho @zikalino Please help review this PR when you're available! Thanks a lot!

@Fred-sun
Copy link
Contributor

@yuwzho @zikalino @nitzmahone Please take a review this when you're free? Thank you very much!

@Fred-sun
Copy link
Contributor

@yuwzho @zikalino @nitzmahone review_need

@yungezz yungezz closed this Jul 16, 2019
@yungezz yungezz reopened this Jul 16, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 16, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py:0:0: E337 Argument 'location' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py:0:0: E337 Argument 'name' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py:0:0: E337 Argument 'retention_policy' in argument_spec defines type as 'dict' but documentation doesn't define type
lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py:0:0: E337 Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 16, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 16, 2019
@yungezz
Copy link
Contributor Author

yungezz commented Jul 16, 2019

ready_for_review

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 16, 2019
@Fred-sun
Copy link
Contributor

@nitzmahone @jborean93 Please take a review this PR when you're free! Thank you very much!

nitzmahone
nitzmahone requested changes Jul 24, 2019
View reviewed changes
Copy link
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple little docs things, otherwise LGTM

lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py Outdated
type: list
categories:
description:
- List of categories of logs. These categories are created as is convinient to user. Some Values are Write, Delete and/or Action.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convenient

lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py Outdated
service_bus_rule_id:
description:
- The service bus rule ID of the service bus namespace in which you would like to have Event Hubs created for streaming in the Activity Log.
- format like {serice_bus_resource_id}/authorizationrules{key_name}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service_bus_resource_id

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 24, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 19, 2019
@Fred-sun
Copy link
Contributor

@nitzmahone It has been updated, please help to review it again! thank you very much!

@zikalino
Copy link
Contributor

all minor comments addressed now -- merging

@zikalino zikalino merged commit 749662d into ansible:devel Aug 26, 2019
@zikalino zikalino deleted the yungez-logprofile branch August 26, 2019 21:00
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
@yungezz @adharshsrivatsr
add azure monitor log profile module (ansible#54702)
9a72597 
* add azure monitor log profile module

* fix version

* fix lint

* mark test as unsupported

* fix lint

* fix lint

* Fix the error prompted in the comments
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@yungezz @anas-shami
add azure monitor log profile module (ansible#54702)
dec66c5 
* add azure monitor log profile module

* fix version

* fix lint

* mark test as unsupported

* fix lint

* fix lint

* Fix the error prompted in the comments
@ansible ansible locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone requested changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure cloud has_issue module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yungezz @ansibot @mattclay @Fred-sun @zikalino @nitzmahone