Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Specify Folder for vmware_vm_facts #56125

Closed
codyja opened this issue May 6, 2019 · 5 comments · Fixed by #56298
Closed

VMware: Specify Folder for vmware_vm_facts #56125

codyja opened this issue May 6, 2019 · 5 comments · Fixed by #56298
Assignees
@Akasurde
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community

Comments

@codyja
Copy link

codyja commented May 6, 2019

SUMMARY

It would be fantastic if vmware_vm_facts could be pointed to a folder and only return objects within that folder. For example if I only wanted templates within /builds/ folder, it should complete rather quickly instead of scanning all VMs and templates.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

vmware_vm_facts

ADDITIONAL INFORMATION
- name: Gather only registered virtual machine templates in build folder
  vmware_vm_facts:
    hostname: '{{ vcenter_hostname }}'
    username: '{{ vcenter_username }}'
    password: '{{ vcenter_password }}'
    vm_type: template
    folder: /build/
  delegate_to: localhost
  register: template_facts
@ansibot
Copy link
Contributor

ansibot commented May 6, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 6, 2019

cc @Akasurde @Tomorrow9 @ckotte @dav1x @goneri @lparkes @sumkincpp @warthog9
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 6, 2019

@codyja, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels May 6, 2019
@dapiced
Copy link

dapiced commented May 9, 2019

I have have exactly the same issue !

@Akasurde Akasurde mentioned this issue May 10, 2019
Merged
Akasurde added a commit to Akasurde/ansible that referenced this issue May 10, 2019
@Akasurde
VMware: support folder param in vmware_vm_facts
ca9e880 
folder can be used as a filter while gathering facts about VMs.

Fixes: ansible#56125

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label May 10, 2019
@Akasurde Akasurde changed the title Specify Folder for vmware_vm_facts VMware: Specify Folder for vmware_vm_facts May 10, 2019
@Akasurde
Copy link
Member

Akasurde commented May 10, 2019 •
edited

@codyja @dapiced Could you please review this PR #56298 and let me know if it works for you ? Thanks

needs_info

@Akasurde Akasurde self-assigned this May 10, 2019
@ansibot ansibot added the needs_info This issue requires further information. Please answer any outstanding questions. label May 10, 2019
StephenSorriaux pushed a commit to StephenSorriaux/ansible that referenced this issue May 11, 2019
@Akasurde
VMware: support folder param in vmware_vm_facts (ansible#56298)
9f86257 
folder can be used as a filter while gathering facts about VMs.

Fixes: ansible#56125

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ndclt pushed a commit to ndclt/ansible that referenced this issue Jun 13, 2019
@Akasurde @ndclt
VMware: support folder param in vmware_vm_facts (ansible#56298)
dacd264 
folder can be used as a filter while gathering facts about VMs.

Fixes: ansible#56125

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
bcoca pushed a commit to bcoca/ansible that referenced this issue Feb 21, 2020
@Akasurde @bcoca
VMware: support folder param in vmware_vm_facts (ansible#56298)
b617894 
folder can be used as a filter while gathering facts about VMs.

Fixes: ansible#56125

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Akasurde Akasurde

Labels
affects_2.9 This issue/PR affects Ansible v2.9 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VMware: support folder param in vmware_vm_facts Akasurde/ansible
4 participants
@Akasurde @ansibot @dapiced @codyja