Don't validate ip address for mgmt interface #56136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 6, 2019
This now adds support to run eos tests against ansible/ansible. Depends-On: ansible/ansible#56126 Depends-On: ansible/ansible#56131 Depends-On: ansible/ansible#56136 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Qalthos
reviewed
May 6, 2019
| @@ -23,7 +23,7 @@ | |||
| # Items from those subsets are present | |||
| - "result.ansible_facts.ansible_net_filesystems is defined" #hw | |||
| - "result.ansible_facts.ansible_net_memtotal_mb > 10" #hw | |||
| - "result.ansible_facts.ansible_net_interfaces.Management1.ipv4.masklen > 1" # interfaces | |||
| - "result.ansible_facts.ansible_net_interfaces.Management1" # interfaces | |||
There was a problem hiding this comment.
Is there anything we can assert about this?
There was a problem hiding this comment.
We can, but we should update the testing here to create the ip address first.
ansibot
added
affects_2.9
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 6, 2019
This now adds support to run eos tests against ansible/ansible. Depends-On: ansible/ansible#56126 Depends-On: ansible/ansible#56131 Depends-On: ansible/ansible#56136 Depends-On: ansible/ansible#56140 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
|
Pull-request updated, HEAD is now 84ee713 |
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 7, 2019
This now adds support to run eos tests against ansible/ansible. Depends-On: ansible/ansible#56126 Depends-On: ansible/ansible#56131 Depends-On: ansible/ansible#56136 Depends-On: ansible/ansible#56140 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 7, 2019
This now adds support to run eos tests against ansible/ansible. Depends-On: ansible/ansible#56126 Depends-On: ansible/ansible#56131 Depends-On: ansible/ansible#56136 Depends-On: ansible/ansible#56140 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
justjais
approved these changes
May 7, 2019
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 7, 2019
This now adds support to run eos tests against ansible/ansible. Depends-On: ansible/ansible#56126 Depends-On: ansible/ansible#56131 Depends-On: ansible/ansible#56136 Depends-On: ansible/ansible#56140 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 7, 2019
This now adds support to run eos tests against ansible/ansible. Depends-On: ansible/ansible#56126 Depends-On: ansible/ansible#56131 Depends-On: ansible/ansible#56136 Depends-On: ansible/ansible#56140 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 7, 2019
This now adds support to run eos tests against ansible/ansible. Depends-On: ansible/ansible#56126 Depends-On: ansible/ansible#56131 Depends-On: ansible/ansible#56136 Depends-On: ansible/ansible#56140 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Qalthos
approved these changes
May 8, 2019
It is possible the EOS appliance doesn't have an IP address on the management1 interface, instead just check we have found that interface. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
|
Pull-request updated, HEAD is now f0a0d2a |
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 8, 2019
Depends-On: ansible/ansible#56180 Depends-On: ansible/ansible#56235 Depends-On: ansible/ansible#56136 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Qalthos
approved these changes
May 8, 2019
Qalthos
pushed a commit
to Qalthos/ansible
that referenced
this pull request
May 24, 2019
) It is possible the EOS appliance doesn't have an IP address on the management1 interface, instead just check we have found that interface. Signed-off-by: Paul Belanger <pabelanger@redhat.com> (cherry picked from commit f9589bd) Co-authored-by: Paul Belanger <pabelanger@redhat.com>
abadger
pushed a commit
that referenced
this pull request
May 24, 2019
It is possible the EOS appliance doesn't have an IP address on the management1 interface, instead just check we have found that interface. Signed-off-by: Paul Belanger <pabelanger@redhat.com> (cherry picked from commit f9589bd) Co-authored-by: Paul Belanger <pabelanger@redhat.com>
Qalthos
pushed a commit
to Qalthos/ansible
that referenced
this pull request
May 30, 2019
) It is possible the EOS appliance doesn't have an IP address on the management1 interface, instead just check we have found that interface. Signed-off-by: Paul Belanger <pabelanger@redhat.com> (cherry picked from commit f9589bd) Co-authored-by: Paul Belanger <pabelanger@redhat.com>
Qalthos
pushed a commit
to Qalthos/ansible
that referenced
this pull request
May 30, 2019
) It is possible the EOS appliance doesn't have an IP address on the management1 interface, instead just check we have found that interface. Signed-off-by: Paul Belanger <pabelanger@redhat.com> (cherry picked from commit f9589bd) Co-authored-by: Paul Belanger <pabelanger@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Dont' assume mgmt interface has an ip address
ISSUE TYPE
COMPONENT NAME
eos_facts