Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eos_config: Fix test issues #56180

Merged
merged 7 commits into from
May 9, 2019
Merged

eos_config: Fix test issues #56180

merged 7 commits into from
May 9, 2019

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented May 7, 2019

SUMMARY
ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

eos_config

@Qalthos Qalthos requested review from ganeshrn and gdpak May 7, 2019 16:14
Qalthos
Qalthos commented May 7, 2019
View reviewed changes
lib/ansible/modules/network/eos/eos_config.py Outdated
@@ -440,6 +440,8 @@ def main():
if module.params['diff_against'] == 'session':
if 'diff' in response:
result['diff'] = {'prepared': response['diff']}
elif 'session' not in response:
warnings.append('Configuration not checked against session as session was not used')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an error instead of a warning?

@ansibot
Copy link
Contributor

ansibot commented May 7, 2019

cc @privateip @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 7, 2019

@Qalthos, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels May 7, 2019
@Qalthos Qalthos changed the title eos_config: Fix test issues [WIP] eos_config: Fix test issues May 7, 2019
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label May 7, 2019
@Qalthos Qalthos changed the title [WIP] eos_config: Fix test issues eos_config: Fix test issues May 7, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 7, 2019
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
ea23711 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56180
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger pabelanger mentioned this pull request May 7, 2019
Merged
@pabelanger
Copy link
Contributor

This was pre-merge tested on zuul.ansible.com, and seems to now be passing:

https://logs.zuul.ansible.com/48/48/ea23711cd0a708d2c1f40690d74bd1410c3d2ad4/check/ansible-test-network-integration-eos-devel/eb3d5a4/job-output.html#l5419

pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
12fd23c 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56180
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
ae8c82e 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56180
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
863afef 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56180
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
da42064 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56180
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
84c44ed 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56180
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
6a87f3c 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56180
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented May 8, 2019

cc @NilashishC @ganeshrn @gdpak @justjais @rcarrillocruz
click here for bot help

pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 8, 2019
@pabelanger
DNM - testing
a2a3fe0 
Depends-On: ansible/ansible#56180
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger pabelanger mentioned this pull request May 8, 2019
Closed
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 8, 2019
@pabelanger
DNM - testing
e778aca 
Depends-On: ansible/ansible#56180
Depends-On: ansible/ansible#56235
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger pabelanger mentioned this pull request May 8, 2019
Closed
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 8, 2019
@pabelanger
DNM - testing
ca61b73 
Depends-On: ansible/ansible#56180
Depends-On: ansible/ansible#56235
Depends-On: ansible/ansible#56136
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@justjais justjais merged commit 0bead36 into ansible:devel May 9, 2019
justjais added a commit that referenced this pull request May 9, 2019
@justjais
Revert "eos_config: Fix test issues (#56180)"
a428701 
This reverts commit 0bead36.
@Qalthos Qalthos deleted the eos_config_tests branch May 9, 2019 13:16
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label May 9, 2019
Qalthos added a commit to Qalthos/ansible that referenced this pull request May 24, 2019
@Qalthos
[stable-2.8] eos_config: Fix test issues (ansible#56180)
262b7f5 
* Alter tests to pass

* Change diff_against to make changed work again

* Add another diff_against

* Expose supports_sessions across all EOS connection types

* Change session warning to failure

* supports_sessions needs to be a method to survive the rpc boundary

* Alter tests to match
(cherry picked from commit 0bead36)

Co-authored-by: Nathaniel Case <ncase@redhat.com>
abadger pushed a commit that referenced this pull request May 24, 2019
@Qalthos @abadger
[stable-2.8] eos_config: Fix test issues (#56180) (#56916)
d617e6c 
* [stable-2.8] eos_config: Fix test issues (#56180)

* Alter tests to pass

* Change diff_against to make changed work again

* Add another diff_against

* Expose supports_sessions across all EOS connection types

* Change session warning to failure

* supports_sessions needs to be a method to survive the rpc boundary

* Alter tests to match
(cherry picked from commit 0bead36)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justjais justjais justjais approved these changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

@gdpak gdpak Awaiting requested review from gdpak

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Qalthos @ansibot @pabelanger @justjais @sivel