Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/2.8/56357 #56367

Merged
merged 2 commits into from May 21, 2019
Merged

Backport/2.8/56357 #56367

merged 2 commits into from May 21, 2019

Conversation

tzurE
Copy link
Contributor

@tzurE tzurE commented May 13, 2019

SUMMARY

ibm_storage utils module fix for a bug where null args were being passed. This caused a failure in most of our modules.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ibm_sa_utils

ADDITIONAL INFORMATION
ansible 2.8.0rc3.post0
  config file = None
  configured module search path = [u'/Users/tzure/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/tzure/git/ansible/lib/ansible
  executable location = /Users/tzure/git/ansible/bin/ansible
  python version = 2.7.10 (default, Aug 17 2018, 19:45:58) [GCC 4.2.1 Compatible Apple LLVM 10.0.0 (clang-1000.0.42)]

tzurE added 2 commits May 13, 2019 20:15
@tzurE
IBM_Storage: fixed a bug which caused several of our modules to pass …
5065003 
…unwanted arguments and fail

(cherry picked from commit 13f5cf4)
@tzurE
IBM_Storage: Added a changelog for 56357 bug
3d1b2a9 
(cherry picked from commit 0de770e)
@alonm
Copy link

alonm commented May 13, 2019

Without this fix we have several operations that will fail

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels May 13, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 21, 2019
abadger
abadger reviewed May 21, 2019
View reviewed changes
changelogs/fragments/56357-ibm-storage-unwanted-args-cause-failure.yml
@@ -0,0 +1,2 @@
bugfixes:
- ibm_storage - Added a check for null fields in ibm_storage utils module.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, it's better if changelogs reflect what was changed from the POV of the user. For instance, fixed a traceback when storage options were unset in the initial configuration. (I don't know if that's actually what is happening here, it's just an example ;-)

@abadger abadger merged commit 51fb908 into ansible:stable-2.8 May 21, 2019
@abadger
Copy link
Contributor

abadger commented May 21, 2019

Merged for the 2.8.1 release.

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label May 22, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger abadger left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tzurE @alonm @abadger @sivel @ansibot