Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded ansible user for junos_user integration tests #56452

Merged
merged 1 commit into from May 15, 2019

Conversation

pabelanger
Copy link
Contributor

SUMMARY

Remove hardcoded 'ansible' user for testing.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-test: junos network-integration

pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 15, 2019
Depends-On: ansible/ansible#56452
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented May 15, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:network This issue/PR relates to code supported by the Ansible Network Team. labels May 15, 2019
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 15, 2019
Depends-On: ansible/ansible#56452
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now 6a94633

pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 15, 2019
Depends-On: ansible/ansible#56452
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 15, 2019
Depends-On: ansible/ansible#56452
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now ae57188

pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 15, 2019
Depends-On: ansible/ansible#56452
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now 73e0bfc

pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 15, 2019
Depends-On: ansible/ansible#56452
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now 999aa0e

pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 15, 2019
Depends-On: ansible/ansible#56452
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 15, 2019
Depends-On: ansible/ansible#56452
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 15, 2019
@Qalthos Qalthos merged commit fa7aedc into ansible:devel May 15, 2019
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 15, 2019
Depends-On: ansible/ansible#56452
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 15, 2019
Depends-On: ansible/ansible#56452
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 15, 2019
Depends-On: ansible/ansible#56452
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible that referenced this pull request Jun 10, 2019
…le#56452)

It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible that referenced this pull request Jun 10, 2019
…le#56452)

It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Depends-On: ansible#57639
Depends-On: ansible#57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
abadger pushed a commit that referenced this pull request Jun 17, 2019
It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Depends-On: #57639
Depends-On: #57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
ganeshrn added a commit to ganeshrn/ansible that referenced this pull request Jun 18, 2019
*  Convert the ElementTree object to string
   before dumping the configuration in file.

* Fix netconf plugin to return data_xml object
  if present for the device handler object or else return raw xml.

* Add check to run lldp integration test cases only if lldp is
  supported on the target host

Merged PR to devel
ansible#57309
ansible#57578
ansible#56452

(cherry picked from commit 9c5745a)
(cherry picked from commit 0957835)
(cherry picked from commit 2ca324b)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants