New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded ansible user for junos_user integration tests #56452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 15, 2019
Depends-On: ansible/ansible#56452 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
ansibot
added
affects_2.9
This issue/PR affects Ansible v2.9
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
needs_triage
Needs a first human triage before being processed.
support:network
This issue/PR relates to code supported by the Ansible Network Team.
labels
May 15, 2019
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 15, 2019
Depends-On: ansible/ansible#56452 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Pull-request updated, HEAD is now 6a94633 |
pabelanger
force-pushed
the
temp/junos_user_tests_fix
branch
from
May 15, 2019 12:38
e2a9cf4
to
6a94633
Compare
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 15, 2019
Depends-On: ansible/ansible#56452 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 15, 2019
Depends-On: ansible/ansible#56452 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Pull-request updated, HEAD is now ae57188 |
pabelanger
force-pushed
the
temp/junos_user_tests_fix
branch
from
May 15, 2019 12:58
6a94633
to
ae57188
Compare
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 15, 2019
Depends-On: ansible/ansible#56452 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
force-pushed
the
temp/junos_user_tests_fix
branch
from
May 15, 2019 13:10
ae57188
to
73e0bfc
Compare
Pull-request updated, HEAD is now 73e0bfc |
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 15, 2019
Depends-On: ansible/ansible#56452 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
It is possible we are using a different username then 'ansible' for testing junos. By using ansible_user_id, this should be a more dynamic check. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Pull-request updated, HEAD is now 999aa0e |
pabelanger
force-pushed
the
temp/junos_user_tests_fix
branch
from
May 15, 2019 13:30
73e0bfc
to
999aa0e
Compare
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 15, 2019
Depends-On: ansible/ansible#56452 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 15, 2019
Depends-On: ansible/ansible#56452 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
ganeshrn
approved these changes
May 15, 2019
ansibot
removed
the
needs_triage
Needs a first human triage before being processed.
label
May 15, 2019
Qalthos
approved these changes
May 15, 2019
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 15, 2019
Depends-On: ansible/ansible#56452 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 15, 2019
Depends-On: ansible/ansible#56452 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 15, 2019
Depends-On: ansible/ansible#56452 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible
that referenced
this pull request
Jun 10, 2019
…le#56452) It is possible we are using a different username then 'ansible' for testing junos. By using ansible_user_id, this should be a more dynamic check. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible
that referenced
this pull request
Jun 10, 2019
…le#56452) It is possible we are using a different username then 'ansible' for testing junos. By using ansible_user_id, this should be a more dynamic check. Depends-On: ansible#57639 Depends-On: ansible#57638 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
ganeshrn
added a commit
to ganeshrn/ansible
that referenced
this pull request
Jun 18, 2019
* Convert the ElementTree object to string before dumping the configuration in file. * Fix netconf plugin to return data_xml object if present for the device handler object or else return raw xml. * Add check to run lldp integration test cases only if lldp is supported on the target host Merged PR to devel ansible#57309 ansible#57578 ansible#56452 (cherry picked from commit 9c5745a) (cherry picked from commit 0957835) (cherry picked from commit 2ca324b)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.9
This issue/PR affects Ansible v2.9
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
support:network
This issue/PR relates to code supported by the Ansible Network Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove hardcoded 'ansible' user for testing.
ISSUE TYPE
COMPONENT NAME
ansible-test: junos network-integration