Modules to manage ICX devices

[sushma-alethea]

SUMMARY
Running command to manage ICX device by Ansible automatically.

ISSUE TYPE
New Module Pull Request

COMPONENT NAME
ICX_7150

ADDITIONAL INFORMATION
Achieving of running command to manage ICX device by Ansible automatically.

[ansibot]

@sushma-alethea, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[ansibot]

The test ansible-test sanity --test no-main-display [explain] failed with 1 error:

lib/ansible/plugins/terminal/icx.py:32:7: Display is a singleton, just import and instantiate

click here for bot help

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:28:0: ansible-bad-import-from Import Mapping from ansible.module_utils.common._collections_compat instead of collections

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

click here for bot help

[ansibot]

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

click here for bot help

[ganeshrn]

Please add your Github id as maintainer for the files/modules added in this PR here and ICX platform module documentation here

[ansibot]

cc @acozine @samccann
click here for bot help

[ansibot]

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop expected at most 1 argument, got 2

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-keywords --template-dir=../templates --output-dir=rst/reference_appendices/ ./keyword_desc.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-plugins -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../../hacking/build-ansible.py", line 88, in <module>
    main()
  File "../../hacking/build-ansible.py", line 79, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 775, in main
    plugin_info, categories = get_plugin_info(args.module_dir, limit_to=args.limit_to, verbose=(args.verbosity > 0))
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 344, in get_plugin_info
    doc['options'][key] = normalize_options(opt)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 175, in normalize_options
    if value.get('type') == 'bool' and 'default' in value:
AttributeError: 'AnsibleSequence' object has no attribute 'get'
make: *** [modules] Error 1

click here for bot help

[sushma-alethea]

Ansible team can you please review and merge to devel.

[Akasurde]

@samccann @acozine Could you please take a look for documentation changes ? Rest LGTM.

[ganeshrn]

As per convention generally, network os name is used for network modules within Ansible (there are some exceptions to this). If the modules in the PR are applicable for other Ruckus device series other than ICX it is recommended to rename it after the os name.
ansible_network_os value, in this case, will be icx

Other than that the code changes in PR look good to me.

[sushma-alethea]

@ganeshrn, modules in this PR and all subsequent PRs that we will be rasing are applicable only for Ruckus ICX series devices. So, ansible_network_is name which we have set to icx is fine.
Can you please now merge the PR to devel.

[samccann]

docs portion LGTM

[ganeshrn]

@sushma-alethea Thank you for the contribution
@LindsayHill @samccann @Akasurde Thank you for your reviews