route53: Skip zone listing when hosted_zone_id is set

[bkmeneguello]

SUMMARY

Improve route53 module performance when ZoneID is know

ISSUE TYPE

• Bug Report

COMPONENT NAME

route53

ANSIBLE VERSION

ansible 2.8.3
  config file = /home/bruno/.ansible.cfg
  configured module search path = [u'/home/user/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15+ (default, Nov 27 2018, 23:36:35) [GCC 7.3.0]

CONFIGURATION

OS / ENVIRONMENT

STEPS TO REPRODUCE

• Define a long list of DNS records
• Use a loop with route53 module to update them

route53:
  state: present
  zone: example.com  # should not be required when hosted_zone_id is present
  private_zone: true  # should not be needed when hosted_zone_id is present
  hosted_zone_id: "XXXXXXXXXXX"
  record: "{{ item.name }}"
  ttl: "{{ item.ttl }}"
  type: "{{ item.type }}"
  value: "{{ item.value }}"
  overwrite: true
with_items: "{{ dns_records }}"

EXPECTED RESULTS

Since hosted_zone_id is provided, this should be a simple request to Route53 API

ACTUAL RESULTS

Currently the code in route53.py do a zone lookup witch may lead to a full listing with (possibly) pagination by boto.
This lookup returns a zone reference but only it's id attribute is read.
So, since the hosted_zone_id is the same id obtained above, and is developer responsibility to ensure it's correct, this lookup should be ignored and the provided hosted_zone_id used in place.

[ansibot]

Files identified in the description:

• lib/ansible/modules/cloud/amazon/route53.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @jimbydamonk
click here for bot help

[ansibot]

@bkmeneguello, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help