Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab_deploy_key contains deprecated call to be removed in 2.10 #61893

Closed
abadger opened this issue Sep 5, 2019 · 3 comments
Closed

gitlab_deploy_key contains deprecated call to be removed in 2.10 #61893

abadger opened this issue Sep 5, 2019 · 3 comments
Assignees
@Akasurde
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. module This issue/PR relates to a module. source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community.
Projects
ansible-base 2.10

Comments

@abadger
Copy link
Contributor

abadger commented Sep 5, 2019

SUMMARY

gitlab_deploy_key contains call to Display.deprecated or AnsibleModule.deprecate and is scheduled for removal

lib/ansible/modules/source_control/gitlab_deploy_key.py:244:4: ansible-deprecated-version: Deprecated version ('2.10') found in call to Display.deprecated or AnsibleModule.deprecate
ISSUE TYPE
  • Bug Report
COMPONENT NAME
lib/ansible/modules/source_control/gitlab_deploy_key.py
ANSIBLE VERSION
2.10
CONFIGURATION

N/A

OS / ENVIRONMENT

N/A

STEPS TO REPRODUCE

N/A

EXPECTED RESULTS

N/A

ACTUAL RESULTS

N/A
@abadger abadger added the deprecated This issue/PR relates to a deprecated module. label Sep 5, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 5, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 5, 2019

cc @Lunik @Shaps @dj-wasabi @jlozadad @marwatk @waheedi
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. module This issue/PR relates to a module. source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community. and removed deprecated This issue/PR relates to a deprecated module. labels Sep 5, 2019
@abadger abadger added this to TODO: Backlog, anything can go here. Anyone can work on this after their approved work is done. in ansible-base 2.10 Sep 5, 2019
Akasurde added a commit to Akasurde/ansible that referenced this issue Sep 6, 2019
@Akasurde
gitlab_*: remove deprecated functionalities
7158f2b 
* Documentation update
* Remove deprecated functionalities

Fixes: ansible#61898 ansible#61897 ansible#61896 ansible#61895 ansible#61894 ansible#61893

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this issue Sep 6, 2019
Merged
Akasurde added a commit to Akasurde/ansible that referenced this issue Oct 16, 2019
@Akasurde
gitlab_*: remove deprecated functionalities
6a14800 
* Documentation update
* Remove deprecated functionalities

Fixes: ansible#61898 ansible#61897 ansible#61896 ansible#61895 ansible#61894 ansible#61893

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde added a commit to Akasurde/ansible that referenced this issue Oct 18, 2019
@Akasurde
gitlab_*: remove deprecated functionalities
e241e2f 
* Documentation update
* Remove deprecated functionalities

Fixes: ansible#61898 ansible#61897 ansible#61896 ansible#61895 ansible#61894 ansible#61893

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde added a commit to Akasurde/ansible that referenced this issue Oct 19, 2019
@Akasurde
gitlab_*: remove deprecated functionalities
1b9e93b 
* Documentation update
* Remove deprecated functionalities

Fixes: ansible#61898 ansible#61897 ansible#61896 ansible#61895 ansible#61894 ansible#61893

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot pushed a commit that referenced this issue Oct 20, 2019
@Akasurde @ansibot
gitlab_*: remove deprecated functionalities (#61912)
f92c99b 
* Documentation update
* Remove deprecated functionalities

Fixes: #61898 #61897 #61896 #61895 #61894 #61893

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde
Copy link
Member

PR #61912 merged. Closing this.

@Akasurde Akasurde self-assigned this Oct 21, 2019
@ansible ansible locked and limited conversation to collaborators Nov 18, 2019
@sivel sivel moved this from TODO: Backlog, anything can go here. Anyone can work on this after their approved work is done. to Merged: PR has been merged but still blocks release until someone checks whether it has all the release criteria in ansible-base 2.10 Jan 20, 2020
@sivel sivel moved this from Merged: PR has been merged but still blocks release until someone checks whether it has all the release criteria to Done: Only PM, RM, or Eng Manager use this colum. Means Tests, documentation, everything is done. in ansible-base 2.10 Jan 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Akasurde Akasurde

Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. module This issue/PR relates to a module. source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community.
Projects
No open projects
ansible-base 2.10
  
Done: Only PM, RM, or Eng Manager use...
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abadger @Akasurde @ansibot