Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab_*: remove deprecated functionalities #61912

Merged
merged 1 commit into from Oct 20, 2019
Merged

gitlab_*: remove deprecated functionalities #61912

merged 1 commit into from Oct 20, 2019

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Sep 6, 2019

SUMMARY
  • Documentation update
  • Remove deprecated functionalities

Fixes: #61898 #61897 #61896 #61895 #61894 #61893

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/source_control/gitlab_deploy_key.py
lib/ansible/modules/source_control/gitlab_group.py
lib/ansible/modules/source_control/gitlab_hook.py
lib/ansible/modules/source_control/gitlab_project.py
lib/ansible/modules/source_control/gitlab_runner.py
lib/ansible/modules/source_control/gitlab_user.py

@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2019

cc @Lunik @SamyCoenen @Shaps @dj-wasabi @jlozadad @marwatk @waheedi
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. gitlab Gitlab community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community. labels Sep 6, 2019
gundalow
gundalow reviewed Sep 6, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need to put anything in Porting guide?

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2019
@Lunik
Copy link
Contributor

Lunik commented Sep 6, 2019

This PR is going to have issue with #60425 (if merged)

@gundalow
Copy link
Contributor

gundalow commented Sep 6, 2019

@Lunik Good spot, thanks for mentioning that. What do you think is the best way to deal with this?

@Akasurde
Copy link
Member Author

Akasurde commented Sep 6, 2019 •
edited

Aren't these options supposed to be removed in 2.10 release ?

@Lunik
Copy link
Contributor

Lunik commented Sep 6, 2019

#60425 should be merge in 2.9 because peoples are reporting issues using GitLab's modules (ex : #59976)
If not, those parameters will be an issue during the 2.9 life cycle.
However #61912 will still be applicated for 2.10

@gundalow gundalow mentioned this pull request Sep 10, 2019
Merged
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 14, 2019
@Shaps
Copy link
Contributor

Shaps commented Oct 2, 2019

I'd agree with @Lunik to merge #60425 first so we have better warnings for the 2.9 lifetime, then merge this.

@Shaps
Copy link
Contributor

Shaps commented Oct 16, 2019

@Akasurde now that #60425 has been merged, can you rebase this so we can move it forward?

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 16, 2019
@Akasurde
Copy link
Member Author

@Shaps Thanks for the heads up. I rebased the branch, please check and let me know. Thanks,

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 16, 2019
Lunik
Lunik reviewed Oct 16, 2019
View reviewed changes
Copy link
Contributor

@Lunik Lunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first look, it seems good.

Lunik
Lunik suggested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@Lunik Lunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those line are useless

lib/ansible/modules/source_control/gitlab_runner.py Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 16, 2019
@Lunik
Copy link
Contributor

Lunik commented Oct 18, 2019

This issue require #63690 to be merged first for backporting in 2.8 and 2.9

@Akasurde
gitlab_*: remove deprecated functionalities
1b9e93b 
* Documentation update
* Remove deprecated functionalities

Fixes: ansible#61898 ansible#61897 ansible#61896 ansible#61895 ansible#61894 ansible#61893

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde
Copy link
Member Author

@Lunik Can you re-review this ? Thanks.

@Lunik
Copy link
Contributor

Lunik commented Oct 20, 2019

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 20, 2019
@ansibot ansibot merged commit f92c99b into ansible:devel Oct 20, 2019
@Akasurde Akasurde deleted the i61898 branch October 21, 2019 15:50
@Akasurde
Copy link
Member Author

@Lunik @Shaps @gundalow Thanks for the review.

This was referenced Oct 21, 2019
Closed
Closed
Closed
Closed
Closed
@ansible ansible locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

@Lunik Lunik Lunik requested changes

@abadger abadger Awaiting requested review from abadger

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. gitlab Gitlab community module This issue/PR relates to a module. shipit This PR is ready to be merged by Core source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gitlab_user contains deprecated call to be removed in 2.10
5 participants
@Akasurde @ansibot @Lunik @gundalow @Shaps