Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible PPA does not build on xenial and trusty #64160

Closed
abadger opened this issue Oct 31, 2019 · 4 comments · Fixed by #64412
Closed

Ansible PPA does not build on xenial and trusty #64160

abadger opened this issue Oct 31, 2019 · 4 comments · Fixed by #64412
Assignees
@goneri
Labels
affects_2.9 This issue/PR affects Ansible v2.9 affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@abadger
Copy link
Contributor

abadger commented Oct 31, 2019 •
edited
Loading

SUMMARY

The 2.9.0 build of ansible on the ansible PPA errored out for Xenial and Trusty:

https://launchpadlibrarian.net/448150215/buildlog_ubuntu-xenial-amd64.ansible_2.9.0~rc5-1ppa~xenial_BUILDING.txt.gz

My guess is that this commit is what broke it: e14ccbf

I'm further guessing that trusty and xenial are using an older version of the debhelper scripts (in particular, dh_installdirs) which are using site-packages whereas the new versions of debhelper use dist-packages.

Output from the failed run specifies --install-purelib=/usr/lib/python2.7/site-packages/ on the commandline:

dh_installdirs -pansible 
cd . && \
	python setup.py install \
	--root="/<<PKGBUILDDIR>>/debian/tmp/" \
	--install-purelib=/usr/lib/python2.7/site-packages/ \
	--prefix=/usr --no-compile -O0

Whereas a successful run on Bionic does not:

dh_installdirs -pansible \
	
dh_installdirs: Compatibility levels before 9 are deprecated (level 5 in use)
cd . && python setup.py install --root="/<<PKGBUILDDIR>>/debian/tmp/" --install-layout=deb --no-compile -O0
ISSUE TYPE
  • Bug Report
COMPONENT NAME

packaging/debian/ansible.install
packaging/debian/ansible-test.install

ANSIBLE VERSION
2.9.0
devel
CONFIGURATION
OS / ENVIRONMENT
STEPS TO REPRODUCE

Build an Ansible pre-release in Jenkins, uploading to launchpad.




EXPECTED RESULTS



Builds on all Ubuntu versions are successful


ACTUAL RESULTS


Note that there are failed builds on this page:  https://launchpad.net/~ansible/+archive/ubuntu/ansible-2.9







      		
    

      
  





        

            

            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @abadger
abadger




          added
  the 

  P2

  Priority 2 - Issue Blocks Release
 label


      Oct 31, 2019

    

  



  
    

    

      
    

    


      

          @abadger
abadger




            added
      

  affects_2.10

  This issue/PR affects Ansible v2.10

      

  affects_2.9

  This issue/PR affects Ansible v2.9

  labels


      Oct 31, 2019

    

  








      

  
      



  

  @ansibot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Contributor


      

  


  

    

      

      
            ansibot
  

      

      

      commented


        Oct 31, 2019


      
    


  





      


        


  
    

      
          
Files identified in the description:



If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibot
ansibot




            added
      

  bug

  This issue/PR relates to a bug.

      

  support:core

  This issue/PR relates to code supported by the Ansible Engineering Team.

  labels


      Oct 31, 2019

    

  



    







      

  
      



  

  @abadger





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Contributor


      

  Author


  


  

    

      

      
            abadger
  

      

      

      commented


        Oct 31, 2019


      
    


  





      


        


  
    

      
          
@goneri is going to look into this

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @goneri





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Contributor


      

  


  

    

      

      
            goneri
  

      

      

      commented


        Oct 31, 2019


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
      Loading

      
    
  



    


  





      


        


  
    

      
          
Trusty is old now. @abadger, What is our policy regarding which version we support?

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @ansibot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Contributor


      

  


  

    

      

      
            ansibot
  

      

      

      commented


        Oct 31, 2019


      
    


  





      


        


  
    

      
          
Files identified in the description:



If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          


  
    
  
  

    
  goneri 

      added a commit
        to goneri/ansible
      that referenced
      this issue

    
      Nov 4, 2019
    
    

      


  

    

      


  

      
        @goneri
  





      

        
          debian: install lib in dist-packages
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          080a825
        
      

    

  

    

      
On Ubuntu Precise and Trusty, the build was failing because the Ansible
libs were installed in /usr/lib/python2.7/site-packages.

According to the Debian Policy (2.5), they should actually be install in
/usr/lib/python2.7/dist-packages This is also CDBS default behaviour since
0.4.131.

See: https://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html

Closes: ansible#64160

    




    

  




  


  
    
  
  

    
  goneri 

      added a commit
        to goneri/ansible
      that referenced
      this issue

    
      Nov 4, 2019
    
    

      


  

    

      


  

      
        @goneri
  





      

        
          debian: install lib in dist-packages
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          63a294f
        
      

    

  

    

      
On Ubuntu Precise and Trusty, the build was failing because the Ansible
libs were installed in /usr/lib/python2.7/site-packages.

According to the Debian Policy (2.5), they should actually be install in
/usr/lib/python2.7/dist-packages This is also CDBS default behaviour since
0.4.131.

See: https://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html

Closes: ansible#64160

    




    

  




  

  

    
  


  

      

    @goneri
goneri



    mentioned this issue
    
      Nov 4, 2019
    





  


  

      
   Merged

  







  




    

    


  


  
    
  
  

    
  bcoca 

      pushed a commit
      that referenced
      this issue

    
      Nov 5, 2019
    
    

      


  

    

      


  

      
        @goneri
      
        @bcoca
  





      

        
          debian: install lib in dist-packages (#64412)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          519e4f4
        
      

    

  

    

      
On Ubuntu Precise and Trusty, the build was failing because the Ansible
libs were installed in /usr/lib/python2.7/site-packages.

According to the Debian Policy (2.5), they should actually be install in
/usr/lib/python2.7/dist-packages This is also CDBS default behaviour since
0.4.131.

See: https://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html

Closes: #64160

    




    

  




  


  
    
  
  

    
  goneri 

      added a commit
        to goneri/ansible
      that referenced
      this issue

    
      Nov 5, 2019
    
    

      


  

    

      


  

      
        @goneri
  





      

        
          debian: install lib in dist-packages (ansible#64412)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          c009b03
        
      

    

  

    

      
On Ubuntu Precise and Trusty, the build was failing because the Ansible
libs were installed in /usr/lib/python2.7/site-packages.

According to the Debian Policy (2.5), they should actually be install in
/usr/lib/python2.7/dist-packages This is also CDBS default behaviour since
0.4.131.

See: https://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html

Closes: ansible#64160

    




    

  




  

  

    
  


  

      

    @goneri
goneri



    mentioned this issue
    
      Nov 5, 2019
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  goneri 

      added a commit
        to goneri/ansible
      that referenced
      this issue

    
      Nov 5, 2019
    
    

      


  

    

      


  

      
        @goneri
  





      

        
          [stable-2.9] debian: install lib in dist-packages (ansible#64412)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          db1e724
        
      

    

  

    

      
On Ubuntu Precise and Trusty, the build was failing because the Ansible
libs were installed in /usr/lib/python2.7/site-packages.

According to the Debian Policy (2.5), they should actually be install in
/usr/lib/python2.7/dist-packages This is also CDBS default behaviour since
0.4.131.

See: https://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html

Closes: ansible#64160

    




    

  




  


  
    
  
  

    
  mattclay 

      pushed a commit
      that referenced
      this issue

    
      Nov 12, 2019
    
    

      


  

    

      


  

      
        @goneri
      
        @mattclay
  





      

        
          [stable-2.9] debian: install lib in dist-packages (#64412)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          6d829b0
        
      

    

  

    

      
On Ubuntu Precise and Trusty, the build was failing because the Ansible
libs were installed in /usr/lib/python2.7/site-packages.

According to the Debian Policy (2.5), they should actually be install in
/usr/lib/python2.7/dist-packages This is also CDBS default behaviour since
0.4.131.

See: https://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html

Closes: #64160

    




    

  




  

  

    
  


  

      

    @ichekaldin
ichekaldin



    mentioned this issue
    
      Nov 14, 2019
    





  


  

      
  
  Closed

  







  




    

    

      
    

    


      

          @ansible
ansible




        locked and limited conversation to collaborators


      Dec 3, 2019

    

  



  


  
    
  
  

    
  anshulbehl 

      pushed a commit
        to anshulbehl/ansible
      that referenced
      this issue

    
      Dec 10, 2019
    
    

      


  

    

      


  

      
        @goneri
      
        @anshulbehl
  





      

        
          debian: install lib in dist-packages (ansible#64412)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          6f5f94d
        
      

    

  

    

      
On Ubuntu Precise and Trusty, the build was failing because the Ansible
libs were installed in /usr/lib/python2.7/site-packages.

According to the Debian Policy (2.5), they should actually be install in
/usr/lib/python2.7/dist-packages This is also CDBS default behaviour since
0.4.131.

See: https://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html

Closes: ansible#64160

    




    

  




  









  
  

    

      

  





  




  
  

             

  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.


  


  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
    @goneri
  
    goneri
    

      








      


  


  

    Labels
  



    

      

    affects_2.9

  This issue/PR affects Ansible v2.9
  

    affects_2.10

  This issue/PR affects Ansible v2.10
  

    bug

  This issue/PR relates to a bug.
  

    P2

  Priority 2 - Issue Blocks Release
  

    support:core

  This issue/PR relates to code supported by the Ansible Engineering Team.








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      debian: install lib in dist-packages

    
      goneri/ansible
    





    
  




        
      

    

  
      

  

    

      3 participants
    

    

        
          @goneri 
        
          @abadger 
        
          @ansibot