Mount module fails on nfs mounts with "as it does not exist'

[wirerydr]

SUMMARY

When using the ansible 'mount' module to mount an NFS export, the play fails with an error containing "... as it does not exist".

ISSUE TYPE

• Bug Report

COMPONENT NAME

Ansible module mount

ANSIBLE VERSION

ansible 2.10.0.dev0
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /var/data/src/ansible/lib/ansible
  executable location = /var/data/src/ansible/bin/ansible
  python version = 3.7.5 (default, Oct 17 2019, 12:16:48) [GCC 9.2.1 20190827 (Red Hat 9.2.1-1)]

CONFIGURATION

COLOR_VERBOSE(/etc/ansible/ansible.cfg) = dark gray
RETRY_FILES_ENABLED(/etc/ansible/ansible.cfg) = False

OS / ENVIRONMENT

Output of hostnamectl:

hostnamectl
   Static hostname: ansible-f31.example.com
         Icon name: computer-vm
           Chassis: vm
        Machine ID: 9af65fda237345db8f54e2fff640148b
           Boot ID: 88abdd71dcf048ea90680629998be20c
    Virtualization: vmware
  Operating System: Fedora 31 (Thirty One)
       CPE OS Name: cpe:/o:fedoraproject:fedora:31
            Kernel: Linux 5.3.15-300.fc31.x86_64
      Architecture: x86-64

STEPS TO REPRODUCE

It appears that commit d2f45da changed the mount module in such a way that will always fail when working with NFS remote mounts.

The commit resulted in code including the following snippet:

    elif state == 'mounted':
        if not os.path.exists(args['src']):
             module.fail_json(msg="Unable to mount %s as it does not exist" % args['src']) 

This would seem to always fail. Simply commenting out lines 2 and 3 in the above snippet restores successful completion.

EXPECTED RESULTS

When doing NFS mounts, Ansible should either use something like showmount` -e <nfsservername> to verify if the remote export exists, or skip validation entirely in the case of NFS mounts.

ACTUAL RESULTS

The play fails with an error including the text "as it does not exist".

[ansibot]

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

Files identified in the description:

• lib/ansible/modules/system/mount.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @jtyr
click here for bot help

[Akasurde]

resolved_by_pr #65544

[Akasurde]

@wirerydr, Could you please check PR #65544 and let us know if it works for you ?

Please check How to test a PR for more help.

Thanks.

needs_info

[wirerydr]

@wirerydr, Could you please check PR #65544 and let us know if it works for you ?

Please check How to test a PR for more help.

Thanks.

needs_info

Tested PR #65544 within the (otherwise) same environment that originally manifested my problem, as documented by this bug report. The following scenarios were tested:

1. With new Mount module parameter verify_src omitted. Originally-documented error re-manifested. Results as expected, as-per documented default value of yes.
2. With verify_src=yes. Originally-documented error re-manifested. Results as expected.
3. With verify_src=no. The play now completed successfully, fstab was correctly updated, and the mounts were all successfully mounted. Results as expected.

This would seem to address the issue raised by this bug-report, at-least for me. Thank you very much for the quick turnaround.

[ansibot]

@wirerydr This issue is waiting for your response. Please respond or the issue will be closed.

click here for bot help

[ansibot]

@wirerydr You have not responded to information requests in this issue so we will assume it no longer affects you. If you are still interested in this, please create a new issue with the requested information.

click here for bot help

[patrakov]

Please reopen, the bug is still there, and has a pull request, #65869

[s-hertel]

Reopening as per above. Not exactly sure why the bot closed this.

bot_status

[ansibot]

Components

lib/ansible/modules/system/mount.py
support: core
maintainers: ansible jtyr

Metadata

waiting_on: wirerydr
needs_info: True

click here for bot help

[wirerydr]

(Speaking as the originator of this bug report)

Something weird is going on - Ansibot seems to be expecting feedback from me, but I pulled the PR, tested it, and provided feedback (to this issue on this comment thread) nearly 3 months ago - Please refer to #65855 (comment).

Please let me know if anything further is required from me, and I will happily provide it.

WireRydr