Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for ansible-console usability. #73665

Merged
merged 1 commit into from Mar 1, 2021
Merged

Fixes for ansible-console usability. #73665

merged 1 commit into from Mar 1, 2021

Conversation

ylmrx
Copy link
Contributor

@ylmrx ylmrx commented Feb 19, 2021 •
edited

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

ansible-console

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 19, 2021
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Feb 23, 2021
bcoca
bcoca requested changes Feb 25, 2021
View reviewed changes
Copy link
Member

@bcoca bcoca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a changelog, also not sure about the change in Ctrl+C, might need a toggle and deprecation period

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 25, 2021
@ylmrx ylmrx force-pushed the fix/ansible_console_docstrings branch from 03216bf to 85afef2 Compare March 1, 2021 16:28
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 1, 2021
@ansibot
Copy link
Contributor

ansibot commented Mar 1, 2021

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

changelogs/fragments/73665-fixes-ansible-console.yml:9:1: empty-lines: too many blank lines (1 > 0)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 1, 2021
@ylmrx
Fixes for ansible-console usability
bccb828 
 - Fix Ctrl+C/D behavior (ansible#68529)
 - correct few typos and missing infos
 - Fixes doc (ansible#72195)
@ylmrx ylmrx force-pushed the fix/ansible_console_docstrings branch from 68387c0 to bccb828 Compare March 1, 2021 17:33
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Mar 1, 2021
@bcoca bcoca merged commit e7e3c12 into ansible:devel Mar 1, 2021
@ansible ansible locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

Assignees

@bcoca bcoca

Labels
affects_2.11 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible-console catches KeyboardInterrupt silently
4 participants
@ylmrx @ansibot @bcoca @samdoran