-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for ansible-console usability. #73665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoca
requested changes
Feb 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a changelog, also not sure about the change in Ctrl+C, might need a toggle and deprecation period
03216bf
to
85afef2
Compare
The test
|
- Fix Ctrl+C/D behavior (ansible#68529) - correct few typos and missing infos - Fixes doc (ansible#72195)
68387c0
to
bccb828
Compare
bcoca
approved these changes
Mar 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.11
bug
This issue/PR relates to a bug.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
new_contributor
This PR is the first contribution by a new community member.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
KeyboardInterrupt
silently #68529 : changed Ctrl+C and Ctrl+D , to something closer to a standard shell behavior. (ie. cancel/reset current line, end session instead of aborting current session)KeyboardInterrupt
silently #68529 : added an exit messageISSUE TYPE
COMPONENT NAME
ansible-console