Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-console catches KeyboardInterrupt silently #68529

Closed
farisachugthai opened this issue Mar 28, 2020 · 6 comments · Fixed by #73665
Closed

ansible-console catches KeyboardInterrupt silently #68529

farisachugthai opened this issue Mar 28, 2020 · 6 comments · Fixed by #73665
Labels
affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@farisachugthai
Copy link

farisachugthai commented Mar 28, 2020


name: ✨ Feature request
about: Suggest an idea for this project

SUMMARY

Leave an exit message when catching KeyboardInterrupt in ansible/lib/console

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

ansible/lib/ansible/cli/console.py

ADDITIONAL INFORMATION

except KeyboardInterrupt:

ansible-console catches KeyboardInterrupt silently.

This may confuse new users, and a simple 'Exiting REPL!' before that self.do_exit would probably be helpful for someone trying the REPL for the first time.

I'll admit I was confused and didn't even realize I was back in my normal shell at first.

Alternatively, if this behavior could be made configurable with something as simple as a class or instance attribute or something that would amazing.

@ansibot
Copy link
Contributor

ansibot commented Mar 28, 2020

Files identified in the description:
None

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 28, 2020

@farisachugthai: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type
  • ansible version
  • component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE.md

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 28, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 21, 2020
@ansibot
Copy link
Contributor

ansibot commented May 15, 2020

@farisachugthai This issue is waiting for you to provide the requested data in the description. Please edit the description or the issue will be closed.

click here for bot help

@farisachugthai
Copy link
Author

I believe I've updated the issue appropriately.

@ansibot ansibot added feature This issue/PR relates to a feature request. and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels May 19, 2020
@ansibot
Copy link
Contributor

ansibot commented May 19, 2020

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

ylmrx added a commit to ylmrx/ansible that referenced this issue Feb 19, 2021
 - Fix Ctrl+C/D behavior (ansible#68529)
 - correct few typos and missing infos
 - Fixes doc (ansible#72195)
ylmrx added a commit to ylmrx/ansible that referenced this issue Feb 19, 2021
 - Fix Ctrl+C/D behavior (ansible#68529)
 - correct few typos and missing infos
 - Fixes doc (ansible#72195)
ylmrx added a commit to ylmrx/ansible that referenced this issue Feb 19, 2021
 - Fix Ctrl+C/D behavior (ansible#68529)
 - correct few typos and missing infos
 - Fixes doc (ansible#72195)
ylmrx added a commit to ylmrx/ansible that referenced this issue Mar 1, 2021
 - Fix Ctrl+C/D behavior (ansible#68529)
 - correct few typos and missing infos
 - Fixes doc (ansible#72195)
ylmrx added a commit to ylmrx/ansible that referenced this issue Mar 1, 2021
 - Fix Ctrl+C/D behavior (ansible#68529)
 - correct few typos and missing infos
 - Fixes doc (ansible#72195)
bcoca pushed a commit that referenced this issue Mar 1, 2021
- Fix Ctrl+C/D behavior (#68529)
 - correct few typos and missing infos
 - Fixes doc (#72195)
@ansible ansible locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants