Ensure provided mode is compared on equal grounds with existing mode #14769
Conversation
We noticed that doing template/copy on files with a slightly different octal mode than expected, check-mode would result in a change, while a real run would return ok. We traced this to the fact that Ansible converts existing permissions using sstat.S_IMODE(), however it doesn't do so with the provided mode. So when we provided '00755', it compared '0755' with '00755'. In a real run this would be equal, but in check-mode it would be considered a change.
…(Python 1.9) This is a backport of ansible#14769 We noticed that doing template/copy on files with a slightly different octal mode than expected, check-mode would result in a change, while a real run would return ok. We traced this to the fact that Ansible converts existing permissions using sstat.S_IMODE(), however it doesn't do so with the provided mode. So when we provided '00755', it compared '0755' with '00755'. In a real run this would be equal, but in check-mode it would be considered a change.
|
I don't think anyone ever tried setting the 'filesystem type' part of the mode before ... I'm not sure if we should 'accept' it and deal with it or error out as it seems like bad input. |
|
I understand. What I wanted to fix was the difference between check-mode and a real run. Currently a real run does accept the "raw" file mode and handles it correctly. So I fixed the check-mode to do the same. Again, as you say, it's unlikely a lot of people will experience this. PS The meaning of 'mode' is in fact the complete file mode, and not just the permission bits. So if we just take it by its name we should be liberal to what we accept... :-) |
|
@dagwieers there are probably a dozen people that would interpret mode that way, outside the other 10 that actually implement this feature inside the filesystem. Most understand mode as the permissions, specially since that is the only things most people have access to change, the other 'mode bits' are just descriptive of what the filesystem object is and not really meant to be changed directly by the user (would be fun changing filetype from device to symlink ....) . |
|
I completely missed the link between this pull and issue #14771. Sorry for that. Please, ignore my fix. |
bcoca
added
the
needs_revision
jimi-c
removed
the
needs_revision
ansibot
added
bug
Issue Type:
This fixes #14771 for Ansible 2.x
Ansible Version:
Summary:
We noticed that doing template/copy on files with a slightly different octal mode than expected, check-mode would result in a change, while a real run would return ok.
We traced this to the fact that Ansible converts existing permissions using sstat.S_IMODE(), however it doesn't do so with the provided mode. So when we provided '0100755', it compared '0755' with '0100755'. In a real run this would be equal, but in check-mode it would be considered a change.