Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure provided mode is compared on equal grounds with existing mode #14769

Closed
wants to merge 1 commit into from
Closed

Ensure provided mode is compared on equal grounds with existing mode #14769

wants to merge 1 commit into from

Commits on Mar 3, 2016

  1. Ensure provided mode is compared on equal grounds with existing mode 

    We noticed that doing template/copy on files with a slightly different octal mode than expected, check-mode would result in a change, while a real run would return ok. We traced this to the fact that Ansible converts existing permissions using sstat.S_IMODE(), however it doesn't do so with the provided mode. So when we provided '00755', it compared '0755' with '00755'. In a real run this would be equal, but in check-mode it would be considered a change.
    @dagwieers
    dagwieers committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    81c2623 View commit details
    Browse the repository at this point in the history