Fix #14454 with_first_found fails with ansible 2

[twouters]

ISSUE TYPE

• Bugfix Pull Request

ANSIBLE VERSION

"ansible 2.0.2.0"

SUMMARY

Two issues popped up while using with_first_found in combination with delegate_to.

The following works fine without delegate_to if file findme exists in <roledir>/templates/ but fails when delegate_to is used.

- name: debugging first_found plugin
  debug: msg="looking for files and found {{ item }}"
  with_first_found:
    - files:
      - "findme"
    - paths:
      - "templates"
  delegate_to: "{{ some_server }}"

The following always fails, regardless of delegate_to if file findme exists in <roledir>/templates/extra/.

- name: debugging first_found plugin
  debug: msg="looking for files and found {{ item }}"
  with_first_found:
    - files:
      - "findme"
    - paths:
      - "templates/extra"

delegate_to breakage

The variable roledir is unavailable when using delegate_to and file lookups will thus only happen in basedir (the directory where the playbook lives).

ansible/lib/ansible/plugins/lookup/first_found.py

Lines 186 to 197 in dee5dba

	if roledir is not None:
	# check the templates and vars directories too,if they exist
	for subdir in ('templates', 'vars', 'files'):
	path = self._loader.path_dwim_relative(roledir, subdir, fn)
	if os.path.exists(path):
	return [path]
	# if none of the above were found, just check the
	# current filename against the current dir
	path = self._loader.path_dwim(fn)
	if os.path.exists(path):
	return [path]

                if roledir is not None:
                    # check the templates and vars directories too,if they exist
                    for subdir in ('templates', 'vars', 'files'):
                        path = self._loader.path_dwim_relative(roledir, subdir, fn)
                        if os.path.exists(path):
                            return [path]

                # if none of the above were found, just check the
                # current filename against the current dir
                path = self._loader.path_dwim(fn)
                if os.path.exists(path):
                    return [path]

suggested fix: It looks like the variable role_path is always available, so we can use that instead of roledir. See commit 5c86c19

paths not considered while looking for files

Provided paths are always ignored and searches will only happen in templates, vars and files directories under roledir.

There seem to be a few issues that cause total_search to be incomplete (i.e. not including the provided paths):

• If pathlist is set during the first iteration of terms, it will be reset to an empty list during any following iterations. Same thing for filelist.
• Appending the file path to total_search results in an infinite loop while iterating filelist, since we're really appending to filelist. So we should copy filelist using list() here. (The infinite loop never hit us because either filelist or pathlist has always been an empty list.)

suggested fix: See commit cd8c0b1

[twouters]

Updated summary, I hope it makes some sense now.

[ansibot]

@twouters This PR was tested by travis-ci.org, which is no longer used. Please rebase your branch to trigger running of current tests.

click here for bot help

[rdxmb]

any chances to get this merged?

[s-hertel]

Thanks for the submission. 9abeecb appears to have fixed the delegate_to bug you found. I think the templates/extra example you made work is predicated on a typo. Here is the fixed example that works for me (note that files and paths are keys of the same dictionary instead):

  - debug: msg="looking for files and found {{ item }}"
    with_first_found:
      - files:
        - findme
        paths:
        - templates/extra

Feel free to stop by IRC or the mailing list if you have questions.

• IRC: #ansible and #ansible-devel on irc.freenode.net
• mailing list: https://groups.google.com/forum/#!forum/ansible-project