Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication methods for hashi_vault lookup plugin #15850

Closed
wants to merge 1 commit into from
Closed

Authentication methods for hashi_vault lookup plugin #15850

wants to merge 1 commit into from

Conversation

Jorge-Rodriguez
Copy link
Contributor

@Jorge-Rodriguez Jorge-Rodriguez commented May 13, 2016 •
edited
Loading

ISSUE TYPE
  • Feature Pull Request
ANSIBLE VERSION
ansible 2.0.2.0
SUMMARY

The hashi_vault lookup only accepts token based authentication, this PR adds username and password, ldap, app-id, github, and tls authentication methods.

@Jorge-Rodriguez Jorge-Rodriguez changed the title Actually use default url. Improvements to hashi_vault lookup plugin May 16, 2016
@Jorge-Rodriguez
Copy link
Contributor Author

Fixes #15495

@Jorge-Rodriguez
Copy link
Contributor Author

@bcoca @techraf ping

@Jorge-Rodriguez
Copy link
Contributor Author

The proposed fixes were already addressed upstream, remodelling the PR as a feature request.

@Jorge-Rodriguez Jorge-Rodriguez changed the title Improvements to hashi_vault lookup plugin Authentication methods for hashi_vault lookup plugin May 16, 2016
@bcoca
Copy link
Member

bcoca commented May 16, 2016

@Jorge-Rodriguez rebase as you have merge commits in the history

@bcoca bcoca added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 16, 2016
Support multiple authentication backends.
4c83df6 
Return more informative error when traversing secrets.

Add documentation line for the  argument.

Fixes to make branch mergeable with latest upstream changes.
@Jorge-Rodriguez
Copy link
Contributor Author

@bcoca rebased

@bcoca bcoca removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 16, 2016
@bcoca
Copy link
Member

bcoca commented May 16, 2016

cc @defionscode

@Jorge-Rodriguez
Copy link
Contributor Author

@bcoca @defionscode Any updates on this PR? The travis build seems to fail from unrelated errors.

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Dec 13, 2016
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Dec 24, 2016
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jan 5, 2017
@ansibot
Copy link
Contributor

ansibot commented Jan 6, 2017

@Jorge-Rodriguez This PR was tested by travis-ci.org, which is no longer used. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html c:plugins/lookup and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 6, 2017
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Feb 1, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2017
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jun 29, 2017
@juliedavila
Copy link
Contributor

@Jorge-Rodriguez you still want this in? We need a rebase as per ansibots last message

@juliedavila
Copy link
Contributor

@Jorge-Rodriguez on a separate note, not sure what the behavior would be if multiple auth methods are passed in. Have you tested that?

@calfonso
Copy link
Contributor

@Jorge-Rodriguez Could you please rebase and respond? Thanks!

@calfonso calfonso added the needs_info This issue requires further information. Please answer any outstanding questions. label Jul 21, 2017
@Jorge-Rodriguez
Copy link
Contributor Author

Right back from holidays, sorry for the delay.
I haven't used this plugin in a year, I'm not even sure if this PR applies anymore.

@defionscode I haven't tested what's the behaviour if multiple auth methods are passed in. If you feel this PR is worth the effort, I can pick it up, otherwise we could close it.

@ansibot ansibot removed the needs_info This issue requires further information. Please answer any outstanding questions. label Jul 31, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 22, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 18, 2018
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Oct 12, 2018
@gundalow
Copy link
Contributor

Hi,
This PR seems to have gotten stuck, so we are going to close it. We like to include community contributions, so this is a difficult call for us. Here's why we're closing this one:

  • It's a feature
  • It was created from an old version of the code
  • We want to clear out the backlog so it's easier to find bug fixes
  • There haven't been any comments or other activity in a long time

If you're the PR author, and you want to start the conversation back up, please:

  • reopen the PR and
  • rebase the branch

If you're a community member, and you want to see this change merged, please:

  • Create a new PR and
  • Reference this author in the git commit & PR and
  • Reference this PR in the new PR

How to rebase a branch: https://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html
How to communicate with the Ansible community: https://docs.ansible.com/ansible/devel/community/communication.html
How to contribute to Ansible: https://docs.ansible.com/ansible/devel/community/index.html

@gundalow gundalow closed this Nov 29, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 c:plugins/lookup feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. plugins/lookup stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jorge-Rodriguez @bcoca @ansibot @juliedavila @calfonso @gundalow