Include vars updated to work with directories #17207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuxdynasty
force-pushed
the
include_vars
branch
2 times, most recently
from
f1220f3
to
2b726c8
Compare
linuxdynasty
force-pushed
the
include_vars
branch
2 times, most recently
from
c6a2697
to
4b72d28
Compare
|
Builds are failing not cause of this module |
include_vars.py now allows you to include an entire directory and its nested directories of variable files.
Added Features..
* Ignore by default *.md, *.py, and *.pyc
* Ignore any list of files.
* Only include files nested by depth (default=unlimited)
* Match only files matching (valid regex)
* Sort files alphabetically and load in that order.
* Sort directories alphabetically and load in that order.
```
- include_vars: 'vars/all.yml'
- name: include all.yml
include_vars:
file: 'vars/all.yml'
- name: include all yml files in vars/all and all nested directories
include_vars:
dir: 'vars/all'
- name: include all yml files in vars/all and all nested directories and save the output in test.
include_vars:
dir: 'vars/all'
name: test
- name: include all yml files in vars/services
include_vars:
dir: 'vars/services'
depth: 1
- name: include only bastion.yml files
include_vars:
dir: 'vars'
files_matching: 'bastion.yml'
- name: include only all yml files exception bastion.yml
include_vars:
dir: 'vars'
ignore_files: 'bastion.yml'
```
linuxdynasty
force-pushed
the
include_vars
branch
from
4b72d28
to
33d0d0d
Compare
|
@nitzmahone Can you check on the build when you have a moment please. @jimi-c I made the changes we discussed on irc. I added the whitelist for (json, yml, and yaml). I kept the ignore_list as a parameter and not as a default that is extended, which I am using currently. I also removed the unit tests in favor of integration tests. |
|
@linuxdynasty Yeah, cryptography did a release this weekend that broke all our remote tests- I stuffed a fix in this afternoon and re-queued your PR build. |
|
Discussed at today's meeting. Merged! Thanks @linuxdynasty for working on this and keeping on top of us to get it reviewed and merged! |
|
Np and thank you guys for all the hard work you guys have done to build a product like Ansible. |
|
@abadger this is the PR for the updated documentation ansible/ansible-modules-core#4609 |
guits
added a commit
to guits/ceph-ansible
that referenced
this pull request
Nov 23, 2016
As introduced in the following PR: - ansible/ansible#17207 we need to refactor our code.
guits
added a commit
to guits/ceph-ansible
that referenced
this pull request
Nov 23, 2016
As introduced in the following PR: - ansible/ansible#17207 we need to refactor our code.
guits
added a commit
to guits/ceph-ansible
that referenced
this pull request
Nov 24, 2016
As introduced in the following PR: - ansible/ansible#17207 we need to refactor our code.
guits
added a commit
to guits/ceph-ansible
that referenced
this pull request
Nov 24, 2016
As introduced in the following PR: - ansible/ansible#17207 we need to refactor our code.
guits
added a commit
to guits/ceph-ansible
that referenced
this pull request
Nov 24, 2016
As introduced in the following PR: - ansible/ansible#17207 we need to refactor our code.
sereinity
pushed a commit
to sereinity-forks/ansible
that referenced
this pull request
Jan 25, 2017
* New features for include_vars
include_vars.py now allows you to include an entire directory and its nested directories of variable files.
Added Features..
* Ignore by default *.md, *.py, and *.pyc
* Ignore any list of files.
* Only include files nested by depth (default=unlimited)
* Match only files matching (valid regex)
* Sort files alphabetically and load in that order.
* Sort directories alphabetically and load in that order.
```
- include_vars: 'vars/all.yml'
- name: include all.yml
include_vars:
file: 'vars/all.yml'
- name: include all yml files in vars/all and all nested directories
include_vars:
dir: 'vars/all'
- name: include all yml files in vars/all and all nested directories and save the output in test.
include_vars:
dir: 'vars/all'
name: test
- name: include all yml files in vars/services
include_vars:
dir: 'vars/services'
depth: 1
- name: include only bastion.yml files
include_vars:
dir: 'vars'
files_matching: 'bastion.yml'
- name: include only all yml files exception bastion.yml
include_vars:
dir: 'vars'
ignore_files: 'bastion.yml'
```
* Added whitelist for file extensisions (yaml, yml, json)
* Removed unit tests in favor of integration tests
ansibot
added
feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
include_vars_dir
ANSIBLE VERSION
SUMMARY
include_vars.py now allows you to include an entire directory and its nested directories of variable files. Created this PR in favor of #17195
Features..
This change is