Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit to query a proxmox with invalid certificate #17247

Closed
wants to merge 3 commits into from
Closed

Permit to query a proxmox with invalid certificate #17247

wants to merge 3 commits into from

Conversation

bmillemathias
Copy link
Contributor

@bmillemathias bmillemathias commented Aug 25, 2016 •
edited
Loading

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

contrib/inventory/proxmox.py

ANSIBLE VERSION
ansible 2.1.1.0
  config file = 
  configured module search path = Default w/o overrides
SUMMARY

Permit to query a proxmox server which doesn't have a proper certificate.

This is a patch which adds an argument to the inventory script for proxmox to permit to query the API even in the absence of valid certificate.
Fixes #15888

@bmillemathias
Permit to query a proxmox with invalid certificate
d789c5a 
Not everybody has a valid certificate in its proxmox installation
@bmillemathias
Permit to query a proxmox with invalid certificate
16519a3 
Not everybody has a valid certificate in its proxmox installation
mscherer
mscherer reviewed Aug 31, 2016
View reviewed changes
contrib/inventory/proxmox.py
parser = OptionParser(usage='%prog [options] --list | --host HOSTNAME')
parser.add_option('--list', action="store_true", default=False, dest="list")
parser.add_option('--host', dest="host")
parser.add_option('--url', default=os.environ.get('PROXMOX_URL'), dest='url')
parser.add_option('--username', default=os.environ.get('PROXMOX_USERNAME'), dest='username')
parser.add_option('--password', default=os.environ.get('PROXMOX_PASSWORD'), dest='password')
parser.add_option('--pretty', action="store_true", default=False, dest='pretty')
parser.add_option('--trust-invalid-certs', action="store_true", default=bool_validate_cert, dest='validate')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if I am not mistaken, if I do not use the option, valide is True. If I use the option, then store_true will mean that validate will also be True. Shouldn't it be the reverse ?

@mscherer mscherer added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 31, 2016
@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Dec 13, 2016
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 5, 2017
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Feb 1, 2017
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Feb 14, 2017
@ansibot
Copy link
Contributor

ansibot commented Apr 11, 2017

@bmillemathias Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_repo This PR no longer has an associated branch as it was removed by the submitter. needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 11, 2017
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jun 29, 2017
@ansibot ansibot added the inventory Inventory category label Jul 19, 2017
@jctanner jctanner mentioned this pull request Jul 21, 2017
Closed
@calfonso
Copy link
Contributor

calfonso commented Aug 3, 2017

@bmillemathias this needs to be rebased in order for it to use the new testing infrastructure. could you do so and we'll finish the review.

@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 7, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@gundalow
Copy link
Contributor

@bmillemathias I'm closing this PR as it's so old it doesn't have support for Shippable. If you are interested in this still please rebase your branch and reopen this PR

If anyone else is interested in this, please

  • fresh PR
  • Link to this PR
  • Credit the original author

Rebase guide: https://docs.ansible.com/ansible/latest/dev_guide/index.html

@gundalow gundalow closed this Nov 29, 2018
@dagwieers dagwieers added the virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) label Feb 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 c:inventory/contrib_script cloud feature This issue/PR relates to a feature request. inventory Inventory category needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_repo This PR no longer has an associated branch as it was removed by the submitter. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bmillemathias @ansibot @calfonso @gundalow @mscherer @dagwieers @jctanner