Skip test_aws.py if boto3/botocore are missing #17814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattclay
reviewed
Sep 29, 2016
| from ansible.module_utils.ec2 import AWSRetry | ||
|
|
||
| if not HAS_BOTO3: | ||
| raise SkipTest("test_aws.py requires the python modules \'boto3\' and \'botocore\'") |
There was a problem hiding this comment.
No need to use a backslash before the single quotes.
|
This is okay as a quick fix but long term splitting into separate targets seems like the way to go. That way when someone runs "make aws_tests" or "make alltests" they know it ran all the tests that it can. |
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
test/units/module_utils/ec2/test_aws.py
SUMMARY
Skip test_aws.py if boto3/botocore are missing