ANSIBLE_SSH_CONTROL_PATH_DIR option added

[Shaps]

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ssh.py

ANSIBLE VERSION

ansible --version
ansible 2.3.0 (ssh_cp_option_fix_18325 e2f63cfa10) last updated 2016/11/03 17:14:11 (GMT +000)
  lib/ansible/modules/core: (detached HEAD 7cc4d3fe04) last updated 2016/11/03 16:38:01 (GMT +000)
  lib/ansible/modules/extras: (detached HEAD e4bc618956) last updated 2016/11/03 16:38:01 (GMT +000)
  config file =
  configured module search path = Default w/o overrides

SUMMARY

This removes the hardcoded value ( $HOME/.ansible/cp ) from ssh.py.
User is able to change the ControlPath directory ( the one that replaces %(directory)s ).

Fixes #18325

# ansible -vvvvvi hosts all -m ping
Using /root/.ansible.cfg as config file
[...]
<localhost> SSH: found only ControlPersist; added ControlPath: (-o)(ControlPath=/tmp/ansible/cp/ansible-ssh-%h-%p-%r)
[...]


# ansible -vvvvvi hosts all -m ping
No config file found; using defaults
[...]
<localhost> SSH: found only ControlPersist; added ControlPath: (-o)(ControlPath=/root/.ansible/cp/ansible-ssh-%h-%p-%r)
[...]

[abadger]

Implementation looks good. Need some documentation.

• Add to examples/ansible.cfg with a short comment about what it does
• Add an entry to docsite/rst/intro_configuration.rst This one can be done in a separate PR if you want so that we don't block dharmabumstead's queue and vice versa.

[Shaps]

Thanks @abadger, yes I forgot to add the ansible.cfg option. Added now.
I will open a separate PR for the docs

[abadger]

Merged to devel. Thanks @Shaps !